From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix RelationIdGetRelation calls that weren't bothering with erro
Date: Sun, 08 Sep 2019 21:01:20 +0000
Message-ID: <E1i74JE-00024V-9J@gemulon.postgresql.org> (raw)
Fix RelationIdGetRelation calls that weren't bothering with error checks.
Some of these are quite old, but that doesn't make them not bugs.
We'd rather report a failure via elog than SIGSEGV.
While at it, uniformly spell the error check as !RelationIsValid(rel)
rather than a bare rel == NULL test. The machine code is the same
but it seems better to be consistent.
Coverity complained about this today, not sure why, because the
mistake is in fact old.
Branch
------
REL_11_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/69f883fef14a3fc5849126799278abcc43f40f56
Modified Files
--------------
src/backend/access/heap/heapam.c | 3 +++
src/backend/replication/logical/reorderbuffer.c | 8 ++++++--
2 files changed, 9 insertions(+), 2 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix RelationIdGetRelation calls that weren't bothering with erro
In-Reply-To: <E1i74JE-00024V-9J@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox