From: Japin Li <japinli@hotmail.com>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Etsuro Fujita <etsuro.fujita@gmail.com>
Cc: onderkalaci@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18467: postgres_fdw (deparser) ignores LimitOption
Date: Fri, 17 May 2024 00:29:47 +0800
Message-ID: <ME3P282MB3166558F8BC9798D4872F915B6ED2@ME3P282MB3166.AUSP282.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <202405161527.2rs7jfxkxl6m@alvherre.pgsql>
References: <ME3P282MB31666446BF8A0C0F7A02D24CB6ED2@ME3P282MB3166.AUSP282.PROD.OUTLOOK.COM>
<202405161527.2rs7jfxkxl6m@alvherre.pgsql>
On Thu, 16 May 2024 at 23:27, Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
> On 2024-May-16, Japin Li wrote:
>
>> I find that the FETCH FIRST ... ROWS WITH TIES does not support type casting.
>> For example:
>>
>> postgres=# SELECT * FROM pg_class ORDER BY relname FETCH FIRST 2::bigint ROWS WITH TIES;
>> ERROR: syntax error at or near "::"
>> LINE 1: ...ECT * FROM pg_class ORDER BY relname FETCH FIRST 2::bigint R...
>> ^
>
> Why do you need this? The standard says
>
> <fetch first clause> ::= FETCH { FIRST | NEXT } [ <fetch first quantity> ] { ROW | ROWS } { ONLY | WITH TIES }
> <fetch first quantity> ::= <fetch first row count> | <fetch first percentage>
> <offset row count> ::= <simple value specification>
> <fetch first row count> ::= <simple value specification>
>
> which doesn't seem to leave room for a cast.
>
> I didn't try super extensively, but this works:
> select 1 from pg_class fetch first 281474976710656 rows only;
> so the count is already not restricted to be an int32 value.
After some dig in, I find transformLimitClause() has the following comments:
* Note: as of Postgres 8.2, LIMIT expressions are expected to yield int8,
* rather than int4 as before.
So the deparseConst() append '::bigint' typecast, same as get_rule_expr().
--
Regards,
Japin Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: japinli@hotmail.com, alvherre@alvh.no-ip.org, etsuro.fujita@gmail.com, onderkalaci@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18467: postgres_fdw (deparser) ignores LimitOption
In-Reply-To: <ME3P282MB3166558F8BC9798D4872F915B6ED2@ME3P282MB3166.AUSP282.PROD.OUTLOOK.COM>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox