public inbox for [email protected]  

help / color / mirror / Atom feed

From: Hayato Kuroda (Fujitsu) <[email protected]>
To: 'Álvaro Herrera' <[email protected]>
To: Vishal Prasanna <[email protected]>
Cc: pgsql-bugs <[email protected]>
Subject: RE: [BUG] Assert failure in ReorderBufferReturnTXN during logical decoding due to leaked specinsert change
Date: Thu, 26 Feb 2026 03:16:32 +0000
Message-ID: <OS9PR01MB12149FD6C66A344831EBD836EF572A@OS9PR01MB12149.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>

Dear Álvaro, Vishal,

> > Yes, the `specinsert` is no longer needed in
> > `ReorderBufferResetTXN()`. Updated the patch where `specinsert`
> > cleanup is now handled in the `PG_CATCH()` block of
> > `ReorderBufferProcessTXN()`, so it is always freed before the if/else
> > branch.
> 
> Please don't do this.  Changing the argument list of an exported
> function is an ABI break.  That's an OK change to do in branch master
> (to keep the interface clean), but for released branches it is not
> welcome, because it causes problems for users that have extensions that
> call the function and were compiled with its older definition.

To confirm, ReorderBufferResetTXN() seems a static function and proposed patch
does not modify *.h files. So they do not break the ABI and OK to remove, right?

Best regards,
Hayato Kuroda
FUJITSU LIMITED

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: RE: [BUG] Assert failure in ReorderBufferReturnTXN during logical decoding due to leaked specinsert change
  In-Reply-To: <OS9PR01MB12149FD6C66A344831EBD836EF572A@OS9PR01MB12149.jpnprd01.prod.outlook.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox