From: Michael Paquier <michael@paquier.xyz>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Pavel Borisov <pashkin.elfe@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: BUG #16663: DROP INDEX did not free up disk space: idle connection hold file marked as deleted
Date: Tue, 1 Dec 2020 11:55:34 +0900
Message-ID: <X8WwpscE7CT9UPHD@paquier.xyz> (raw)
In-Reply-To: <CA+hUKGKbtf_mpxEuUpJt5oZAibYa=cVJ2wB4+NnnkbHfF5jCHQ@mail.gmail.com>
References: <16663-fe97ccf9932fc800@postgresql.org>
<160624299337.7563.13562988821961887884.pgcf@coridan.postgresql.org>
<160624435783.7564.2550264874132085886.pgcf@coridan.postgresql.org>
<CA+hUKGKbtf_mpxEuUpJt5oZAibYa=cVJ2wB4+NnnkbHfF5jCHQ@mail.gmail.com>
On Mon, Nov 30, 2020 at 06:59:40PM +1300, Thomas Munro wrote:
> So I fixed that, by adding a return value to do_truncate() and
> checking it. That's the version I plan to commit tomorrow, unless
> there are further comments or objections. I've also attached a
> version suitable for REL_11_STABLE and earlier branches (with a name
> that cfbot should ignore), where things are slightly different. In
> those branches, the register_forget_request() logic is elsewhere.
Hmm. Sorry for arriving late at the party. But is that really
something suitable for a backpatch? Sure, it is not optimal to not
truncate all the segments when a transaction dropping a relation
commits, but this was not completely broken either.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: michael@paquier.xyz, thomas.munro@gmail.com, pashkin.elfe@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: BUG #16663: DROP INDEX did not free up disk space: idle connection hold file marked as deleted
In-Reply-To: <X8WwpscE7CT9UPHD@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox