pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: David Steele <david@pgmasters.net>
Cc: Антон Курочкин <antkurochkin@gmail.com>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16894: PANIC: WAL contains references to invalid pages
Date: Fri, 5 Mar 2021 13:32:47 +0900
Message-ID: <YEG0bx9RAvbq/RTF@paquier.xyz> (raw)
In-Reply-To: <188742f3-a8d0-20b1-2acb-a038a7d5727b@pgmasters.net>
References: <16894-c29735df12727642@postgresql.org>
	<CABPPpF3mym72xDOyvvfBb4e-rV1Z2Qdip7qQSf2axdnuj-sv=Q@mail.gmail.com>
	<fd63fe44-7858-5b0a-1709-b9a2da11e36c@pgmasters.net>
	<YDxuCMyEeLofajLi@paquier.xyz>
	<11b70b37-997e-8a2d-62f3-0f8398b7cafd@pgmasters.net>
	<YD802EbDVvs4SWo0@paquier.xyz>
	<188742f3-a8d0-20b1-2acb-a038a7d5727b@pgmasters.net>

On Wed, Mar 03, 2021 at 06:49:02AM -0500, David Steele wrote:
> OK, but shouldn't we have a full page write for this page after the backup
> starts, rather than the partial we seem to be seeing here? Is there any
> condition where the full page write would be skipped legitimately, or does
> it point to a problem?

That's how things work.  If they don't work this way for physical
backups, we may have a problem.  At replay, the full page will be
replayed if BKPIMAGE_APPLY is correctly set, as per
XLogReadBufferForRedoExtended().  And XLogRecordAssemble()
does the decision when building the record (just grep for
needs_backup).

> If Postgres is running correctly there is certainly no expectation for
> support of this unusual use case, but I do think that this possibly points
> to an issue in Postgres, which under normal circumstances would be very hard
> to detect.

Well, the report tells that this is an issue that happens on those
fake files full of zeros, but are you sure that you have the sizing
right?  I still don't see any evidence of anything broken based on the
information gathered for full backups, FWIW.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (10+ messages)  latest in thread

Message-ID: <YEG0bx9RAvbq/RTF@paquier.xyz>
Permalink:  ../YEG0bx9RAvbq%2FRTF@paquier.xyz/
Also on:    postgresql.org/message-id/YEG0bx9RAvbq/RTF@paquier.xyz

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-bugs@postgresql.org
  Cc: michael@paquier.xyz, david@pgmasters.net, antkurochkin@gmail.com
  Subject: Re: BUG #16894: PANIC: WAL contains references to invalid pages
  In-Reply-To: <YEG0bx9RAvbq/RTF@paquier.xyz>
  References: <16894-c29735df12727642@postgresql.org> <CABPPpF3mym72xDOyvvfBb4e-rV1Z2Qdip7qQSf2axdnuj-sv=Q@mail.gmail.com> <fd63fe44-7858-5b0a-1709-b9a2da11e36c@pgmasters.net> <YDxuCMyEeLofajLi@paquier.xyz> <11b70b37-997e-8a2d-62f3-0f8398b7cafd@pgmasters.net> <YD802EbDVvs4SWo0@paquier.xyz> <188742f3-a8d0-20b1-2acb-a038a7d5727b@pgmasters.net> <YEG0bx9RAvbq/RTF@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox