From: Michael Paquier <michael@paquier.xyz>
To: Julien Rouhaud <rjuju123@gmail.com>
Cc: t.larionov@postgrespro.ru
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16953: OOB access while converting "interval" to char
Date: Thu, 8 Apr 2021 20:37:21 +0900
Message-ID: <YG7q8YcvFcXCAbAH@paquier.xyz> (raw)
In-Reply-To: <20210408110403.wr3d552xilqsx4us@nol>
References: <16953-f255a18f8c51f1d5@postgresql.org>
<20210407120856.3rjxxnnzzxn74vyv@nol>
<YG7YTjuZXylrjGAv@paquier.xyz>
<20210408110403.wr3d552xilqsx4us@nol>
On Thu, Apr 08, 2021 at 07:04:03PM +0800, Julien Rouhaud wrote:
> I'm fine with it too, although I'd probably go with [-13, 13] just to make sure
> that there's isn't silly off-by-one mistake.
Also, I guess that you'd just want to compile twice a modulo based on
MONTHS_PER_YEAR to get the correct positive position in each array.
> I'll just wait a bit to see if anyone else has any opinion on whether -1 month
> should be January or December.
Sure. If you can send an updated patch, that would be great.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: michael@paquier.xyz, rjuju123@gmail.com, t.larionov@postgrespro.ru, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16953: OOB access while converting "interval" to char
In-Reply-To: <YG7q8YcvFcXCAbAH@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox