From: Michael Paquier <michael@paquier.xyz>
To: Andrey Lepikhov <a.lepikhov@postgrespro.ru>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: Assertion on create index concurrently
Date: Sun, 27 Jun 2021 10:35:49 +0900
Message-ID: <YNfV9WfPh7eduCfM@paquier.xyz> (raw)
In-Reply-To: <9b905019-5297-7372-0ad2-e1a4bb66a719@postgrespro.ru>
References: <9b905019-5297-7372-0ad2-e1a4bb66a719@postgrespro.ru>
On Sat, Jun 26, 2021 at 09:48:45PM +0300, Andrey Lepikhov wrote:
> I found one annoying assertion in the CREATE INDEX CONCURRENTLY operation.
> It will happen if you add into WHERE part of CREATE INDEX CONCURRENTLY some
> function that will make transactional update (see an example in the attached
> patch).
>
> It looks like a hack, but it lead to assertion and restart of the instance,
> that isn't good.
> I suggest to perform error, not assertion in this case (see the patch).
>
> This problem affects PG 9.6 - 13. The master branch was fixed 9 months ago
> by commit 83158f7, that made this operation transactional, but still.
This looks like a good argument for back-patching 83158f7 all the way
down, as 813fb03 exists since 9.4. Any thoughts from others?
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: michael@paquier.xyz, a.lepikhov@postgrespro.ru, pgsql-bugs@lists.postgresql.org
Subject: Re: Assertion on create index concurrently
In-Reply-To: <YNfV9WfPh7eduCfM@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox