pg.ddx.io pgsql-bugs@postgresql.org mailing list archive help / color / mirror / Atom feed From: Michael Paquier <michael@paquier.xyz>
To: Dmitry Koval <d.koval@postgrespro.ru>
Cc: Juan José SantamarÃa Flecha <juanjo.santamaria@gmail.com>
Cc: PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #17288: PSQL bug with COPY command (Windows)
Date: Thu, 25 Nov 2021 12:23:41 +0900
Message-ID: <YZ8BvVysOLJcTP16@paquier.xyz> (raw )
In-Reply-To: <b108ffee-53b7-f11d-4110-1c2a72fa63b2@postgrespro.ru >
References: <4c22d38f-efa9-4d83-c551-707f1770e585@postgrespro.ru >
<CAC+AXB1C1C_z3XQR=ZxiG+V0U9RDJFtJJamvYMoq+d4RoVRh4A@mail.gmail.com >
<9caa0612-19e5-f860-4b97-908a1c721233@postgrespro.ru >
<CAC+AXB1FTZueNdvT1F4fpr4z9gxpcKkgWa-Awor9XC9PAKLVSA@mail.gmail.com >
<YZiGIxk5F3TT/OJc@paquier.xyz >
<ff540eb5-3493-cf02-6c22-20ef6e15fee9@postgrespro.ru >
<CAC+AXB2GfM3NGjx7vc+=UvbD_bzQheiPqk2BQiFRn7G0oVUDhA@mail.gmail.com >
<c97531c7-a439-78b5-33e6-6aab5a900949@postgrespro.ru >
<YZ3Cm7PKGesAitYN@paquier.xyz >
<b108ffee-53b7-f11d-4110-1c2a72fa63b2@postgrespro.ru >
On Wed, Nov 24, 2021 at 10:44:09AM +0300, Dmitry Koval wrote:
> Unfortunately, you are.
> All my COPY-tests work well with files.
> I see a problem in the terminal only ...
While checking all the callers of fstat() in the core code, I have
discovered that this broke a second case when stdout is not
redirected: pg_recvlogical -f -. In this case, the code would just
bump on EINVAL repeatedly instead of crashing, but equally broken it
was. There is a TAP test for this case in src/bin/pg_basebackup/, but
it would not trigger the problem per the redirection already done
there.
Anyway, I have run more tests, tweaked slightly the comment, and
applied it down to 14. Thanks to both of you!
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
view thread (29+ messages) latest in thread
Message-ID: <YZ8BvVysOLJcTP16@paquier.xyz>
Permalink: ../YZ8BvVysOLJcTP16@paquier.xyz/
Also on: postgresql.org/message-id/YZ8BvVysOLJcTP16@paquier.xyz
copy link · copy postgr.es
reply Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: michael@paquier.xyz, d.koval@postgrespro.ru, juanjo.santamaria@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17288: PSQL bug with COPY command (Windows)
In-Reply-To: <YZ8BvVysOLJcTP16@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox