pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Jacob Champion <pchampion@vmware.com>
Cc: tgl@sss.pgh.pa.us
Cc: peter.eisentraut@enterprisedb.com
Cc: pgsql-hackers@lists.postgresql.org
Cc: buschmann@nidsa.net
Cc: andrew@dunslane.net
Cc: noah@leadboat.com
Cc: tomas.vondra@2ndquadrant.com
Cc: bruce@momjian.us
Cc: andres@anarazel.de
Subject: Re: pg_upgrade test for binary compatibility of core data types
Date: Thu, 2 Dec 2021 10:49:22 +0900
Message-ID: <YagmIoTml2NGXWX8@paquier.xyz> (raw)
In-Reply-To: <YaciEMkHNumImMpk@paquier.xyz>
References: <20210430183348.GQ27406@telsasoft.com>
	<a31d593da98da15fc2302a16b3f3b32e491d3e49.camel@vmware.com>
	<20210912005116.GF26465@telsasoft.com>
	<YVa/se5gxr1PsXDy@paquier.xyz>
	<YWPNxDWFia+V4Y4g@paquier.xyz>
	<20211107192200.GK17618@telsasoft.com>
	<YZSov33oDwW44uMs@paquier.xyz>
	<20211118044728.GI17618@telsasoft.com>
	<YZX5ijyrhvEgPAoE@paquier.xyz>
	<YaciEMkHNumImMpk@paquier.xyz>

On Wed, Dec 01, 2021 at 04:19:44PM +0900, Michael Paquier wrote:
> I'll get that done down to 10 to maximize its influence, then I'll
> move on with the buildfarm code and send a patch to plug this and
> reduce the dependencies between core and the buildfarm code.

Okay, I have checked this one this morning, and applied the split down
to 10, so as we have a way to fix objects from the main regression
test suite.  The buildfarm client gets a bit cleaned up after that (I
have a patch for that, but I am not 100% sure that it is right).

Still, the global picture is larger than that because there is still
nothing done for contrib/ modules included in cross-version checks of
pg_upgrade by the buildfarm.  The core code tests don't do this much,
but if we were to do the same things as the buildfarm, then we would
need to run installcheck-world (roughly) on a deployed instance, then
pg_upgrade it.  That's not going to be cheap, for sure.

One thing that we could do is to use unique names for the databases of
the contrib/ modules when running an installcheck, so as these are
preserved for upgrades (the buildfarm client does that).  This has as
effect to increase the number of databases for an instance
installcheck'ed, so this had better be optional, at least.
--
Michael

Attachments:

  [application/pgp-signature] signature.asc (832B, ../YagmIoTml2NGXWX8@paquier.xyz/2-signature.asc)
  download

view thread (36+ messages)

Message-ID: <YagmIoTml2NGXWX8@paquier.xyz>
Permalink:  ../YagmIoTml2NGXWX8@paquier.xyz/
Also on:    postgresql.org/message-id/YagmIoTml2NGXWX8@paquier.xyz

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: michael@paquier.xyz, pryzby@telsasoft.com, pchampion@vmware.com, tgl@sss.pgh.pa.us, peter.eisentraut@enterprisedb.com, pgsql-hackers@lists.postgresql.org, buschmann@nidsa.net, andrew@dunslane.net, noah@leadboat.com, tomas.vondra@2ndquadrant.com, bruce@momjian.us, andres@anarazel.de
  Subject: Re: pg_upgrade test for binary compatibility of core data types
  In-Reply-To: <YagmIoTml2NGXWX8@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox