From: Bruce Momjian <bruce@momjian.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Nathan Bossart <nathandbossart@gmail.com>
Cc: adam@labkey.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18711: Attempting a connection with a database name longer than 63 characters now fails
Date: Mon, 2 Dec 2024 18:37:47 -0500
Message-ID: <Z05Ey-8ABqWUQGYX@momjian.us> (raw)
In-Reply-To: <1692919.1733181379@sss.pgh.pa.us>
References: <Z0Dmw1ryKH8bEkyo@nathan>
<Z0c9XVU6aTd8neRr@nathan>
<1865227.1732723416@sss.pgh.pa.us>
<CA+hUKGKKNAc599Vp7kFAnLE1=V=ceYujz_YQoSNrvNFGaJ6i7w@mail.gmail.com>
<2094158.1732812306@sss.pgh.pa.us>
<CA+hUKGKDC7tKMZ1v0JGH5D23F-=ADf-3UfcriVepqoi7Q_SKgQ@mail.gmail.com>
<Z0mUMnVakLOizwID@ip-10-97-1-34.eu-west-3.compute.internal>
<CA+hUKG+uJGt2tks0jyS=Gkjd0Uig-9cORVm-_igp50m7QwKrWw@mail.gmail.com>
<Z048JXV9f8GczAUa@momjian.us>
<1692919.1733181379@sss.pgh.pa.us>
On Mon, Dec 2, 2024 at 06:16:19PM -0500, Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > I am concerned we are going to get a lot of complaints about this
> > restricted change because most people are happily using whatever
> > encoding they want, and as long as they don't hit the 64-byte limit,
> > they are fine. Are people going to be happy with this restriction just
> > to keep 64+-byte identifiers safe?
>
> That's a remarkably rose-tinted view of the current state of affairs.
> Reality is that using multiple encodings in shared catalogs just plain
> doesn't work very well. Even something as simple as "select datname
> from pg_database" is likely to give garbage if there are entries in
> encodings that don't match your current database's encoding. What
> Thomas is proposing is to formalize and then enforce the two usage
> patterns that we know work okay.
>
> Moreover, the proposal also includes a third backwards-compatibility
> mode that will let anyone who does like the current approach to keep
> using it. So I'm unclear on why you think there's a big downside.
I have not heard of anyone complaining about the problem of viewing the
shared catalog columns so I didn't consider that benefit.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
When a patient asks the doctor, "Am I going to die?", he means
"Am I going to die soon?"
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: bruce@momjian.us, tgl@sss.pgh.pa.us, thomas.munro@gmail.com, bertranddrouvot.pg@gmail.com, nathandbossart@gmail.com, adam@labkey.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18711: Attempting a connection with a database name longer than 63 characters now fails
In-Reply-To: <Z05Ey-8ABqWUQGYX@momjian.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox