pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Alexander Lakhin <exclusion@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: rootcause000@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18146: Rows reappearing in Tables after Auto-Vacuum Failure in PostgreSQL on Windows
Date: Fri, 20 Dec 2024 11:53:43 +0900
Message-ID: <Z2TcN-ypscC4Jomj@paquier.xyz> (raw)
In-Reply-To: <CA+TgmoZj9dJhHQokHioXB8dyDZz5gjzyg7SbUrG=At-uShq7yA@mail.gmail.com>
References: <8e499d50-09ac-479a-b5b2-8a8bca83d057@iki.fi>
	<00477c52-3a35-4621-b80b-58a5a48b113f@iki.fi>
	<CA+hUKG+g8ydXzSnHQPtNhmwNhn8A-FborSZGSLg62tivaugP0g@mail.gmail.com>
	<Zt6h7y308oXttagv@paquier.xyz>
	<CA+hUKGKvb3Dxs1NrfW4_cDZ7LMw4inSMqET5wceswnetWUZVqA@mail.gmail.com>
	<CA+hUKGK+tzjU-vqLr_zA8REzPUyiKNmpxk32Jw5AFR0DZNaXfg@mail.gmail.com>
	<ZyCTXqPG_uGvLJtZ@paquier.xyz>
	<CA+TgmobP2AEjS5qzfEVGugfQw1H+7DF283udewzTDPO3-2G-Kg@mail.gmail.com>
	<CA+hUKGJSOEZWx9zRFFfOfDj9zbVmMbWKRq+ZzMCXftHcO1UYQQ@mail.gmail.com>
	<CA+TgmoZj9dJhHQokHioXB8dyDZz5gjzyg7SbUrG=At-uShq7yA@mail.gmail.com>

On Thu, Dec 19, 2024 at 10:44:05AM -0500, Robert Haas wrote:
> I think mostly my thought was that if we could remove smgrtruncate()
> entirely in favor of smgrtruncatefrom(), or just keep it called
> smgrtruncate() but add a mandatory additional argument, that would be
> less error-prone than having two versions between which future hackers
> must pick.

Hmm.  Indeed.  As a HEAD change, keeping only a smgrtruncate() is
tempting as it creates a parallel with md.c.  I am not completely sure
how to make all that leaner with the smgrnblocks() calls that save the
old number of blocks for each fork.  But perhaps Thomas has a fancy
idea if it comes down to that, and it could always be done later.
--
Michael

Attachments:

  [application/pgp-signature] signature.asc (832B, ../Z2TcN-ypscC4Jomj@paquier.xyz/2-signature.asc)
  download

view thread (45+ messages)  latest in thread

Message-ID: <Z2TcN-ypscC4Jomj@paquier.xyz>
Permalink:  ../Z2TcN-ypscC4Jomj@paquier.xyz/
Also on:    postgresql.org/message-id/Z2TcN-ypscC4Jomj@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: michael@paquier.xyz, robertmhaas@gmail.com, thomas.munro@gmail.com, hlinnaka@iki.fi, exclusion@gmail.com, tgl@sss.pgh.pa.us, laurenz.albe@cybertec.at, rootcause000@gmail.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #18146: Rows reappearing in Tables after Auto-Vacuum Failure in PostgreSQL on Windows
  In-Reply-To: <Z2TcN-ypscC4Jomj@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox