From: Michael Paquier <michael@paquier.xyz>
To: Alexander Lakhin <exclusion@gmail.com>
Cc: Richard Guo <guofenglinux@gmail.com>
Cc: Ankit Kumar Pandey <itsankitkp@gmail.com>
Cc: David Rowley <dgrowleyml@gmail.com>
Cc: Teodor Sigaev <teodor@sigaev.ru>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17888: Incorrect memory access in gist__int_ops for an input array with many elements
Date: Thu, 15 Jun 2023 13:53:36 +0900
Message-ID: <ZIqZUKZ/PpMfbqXT@paquier.xyz> (raw)
In-Reply-To: <ZIlAVBmmAhVaVGHR@paquier.xyz>
References: <17888-f72930e6b5ce8c14@postgresql.org>
<CAMbWs48s6Uhv9wngJVtv=7DGEyN9a-SzwBKsfz2hY7yS6z7ZQw@mail.gmail.com>
<f7ab52bb-e0ee-4acd-9bb1-ac28d22e39f5@gmail.com>
<ZIlAVBmmAhVaVGHR@paquier.xyz>
On Wed, Jun 14, 2023 at 01:21:40PM +0900, Michael Paquier wrote:
> Likely that's something we'd better backpatch, to avoid people playing
> with that too much in the back-branches. Thoughts or objections?
Well, we could perhaps revisit the choice of 08ee64e to remove the
LEAF flag from the data stored. However, seeing the lack of
complaints for the past 18 years with users storing large arrays under
gist__int_ops, spending more time on this is not really appealing,
either. Or we would have heard about that because the decompression
immediately breaks for this case.
I have spent some time on that today, and applied what has been
suggested to restrict the usage of this operator when inserting data
for a leaf page, so as the decompression does not get crazy when
retrieving the contents of the leaf pages.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: michael@paquier.xyz, exclusion@gmail.com, guofenglinux@gmail.com, itsankitkp@gmail.com, dgrowleyml@gmail.com, teodor@sigaev.ru, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17888: Incorrect memory access in gist__int_ops for an input array with many elements
In-Reply-To: <ZIqZUKZ/PpMfbqXT@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox