From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: exclusion@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18135: Incorrect memory access occurs when attaching a partition with an index
Date: Sun, 1 Oct 2023 09:31:39 +0900
Message-ID: <ZRi96-kUPFy0ILzb@paquier.xyz> (raw)
In-Reply-To: <1043711.1695922299@sss.pgh.pa.us>
References: <18135-532f4a755e71e4d2@postgresql.org>
<1043711.1695922299@sss.pgh.pa.us>
On Thu, Sep 28, 2023 at 01:31:39PM -0400, Tom Lane wrote:
> Agreed, that's pretty broken, and it's not just that it risks an
> invalid access. I don't think this reliably rejects cases where
> one index has an expression and the other doesn't. Even if it does
> work, it's way too complicated to convince oneself that that's
> rejected. I think for clarity we should code it as attached.
- /* ignore expressions at this stage */
- if ((info1->ii_IndexAttrNumbers[i] != InvalidAttrNumber) &&
- (attmap->attnums[info2->ii_IndexAttrNumbers[i] - 1] !=
- info1->ii_IndexAttrNumbers[i]))
- return false;
+ /* ignore expressions for now (but check their collation/opfamily) */
+ if (!(info1->ii_IndexAttrNumbers[i] == InvalidAttrNumber &&
+ info2->ii_IndexAttrNumbers[i] == InvalidAttrNumber))
+ {
+ /* fail if just one index has an expression in this column */
+ if (info1->ii_IndexAttrNumbers[i] == InvalidAttrNumber ||
+ info2->ii_IndexAttrNumbers[i] == InvalidAttrNumber)
+ return false;
I can see that this has already been committed as 9f71e10d65, but are
you sure that this is correct? I didn't take the time to reply back,
because I got the feeling that even what I proposed is not correct.
The previous code was careful enough to look at the information from
info2 only *through* the attribute map, which is not what this new
code is doing. Rather than looking directly at the elements in info2
at each iteration, shouldn't this stuff loop over the elements in
attmap->attnums for each info1->ii_IndexAttrNumbers[i]?
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us, exclusion@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18135: Incorrect memory access occurs when attaching a partition with an index
In-Reply-To: <ZRi96-kUPFy0ILzb@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox