From: Michael Paquier <michael@paquier.xyz>
To: Tender Wang <tndrwang@gmail.com>
Cc: Alexander Lakhin <exclusion@gmail.com>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18310: Some SQL commands fail to process duplicate objects with error: tuple already updated by self
Date: Fri, 26 Jan 2024 12:41:16 +0900
Message-ID: <ZbMp3H9oVvubWkR5@paquier.xyz> (raw)
In-Reply-To: <CAHewXN=hBb4=Gr-QHiH95Q8XvLxwTRHLDwR4XmGV5PMU4PgNWQ@mail.gmail.com>
References: <18310-1eb233c5908189c8@postgresql.org>
<ZbMeI3EyyDlP-Agv@paquier.xyz>
<CAHewXN=hBb4=Gr-QHiH95Q8XvLxwTRHLDwR4XmGV5PMU4PgNWQ@mail.gmail.com>
On Fri, Jan 26, 2024 at 11:33:24AM +0800, Tender Wang wrote:
> How about using list *res replace int *res in getTokenTypes(), so we can
> use list_append_unique().
> In outer function, use list *tokens to replace int *tokens, and ntokens =
> list_length(tokens) not list_length(stmt->tokentype).
Yeah, I was wondering about this code path. If you feel strongly
about that, would you like to write a patch?
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../ZbMp3H9oVvubWkR5@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: michael@paquier.xyz, tndrwang@gmail.com, exclusion@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18310: Some SQL commands fail to process duplicate objects with error: tuple already updated by self
In-Reply-To: <ZbMp3H9oVvubWkR5@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox