From: Michael Paquier <michael@paquier.xyz>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: n.kalinin@postgrespro.ru
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18609: Repeated installcheck failure in test_pg_dump due to existing role
Date: Thu, 19 Sep 2024 16:44:58 +0900
Message-ID: <ZuvWeodtN9qwt6Dw@paquier.xyz> (raw)
In-Reply-To: <61043C0D-A79D-457A-AC2A-4719D036FBCD@yesql.se>
References: <18609-4f426b9a2809baa8@postgresql.org>
<61043C0D-A79D-457A-AC2A-4719D036FBCD@yesql.se>
On Wed, Sep 11, 2024 at 10:01:22AM +0200, Daniel Gustafsson wrote:
> That would be backpatching 936e3fa3787a51397280c1081587586e83c20399. I haven't
> checked if there are complications in doing so but I think it should be quite
> straightforward.
As far as I can see it would be enough to add the DROP OWNED BY to
avoid the random notice messages listing the dependencies the role
depends on, followed by the DROP ROLE. FWIW, I am not seeing any
complications (the TAP test recreates the same role name
regress_dump_test_role on its own), so let's just do it.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: michael@paquier.xyz, daniel@yesql.se, n.kalinin@postgrespro.ru, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18609: Repeated installcheck failure in test_pg_dump due to existing role
In-Reply-To: <ZuvWeodtN9qwt6Dw@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox