From: Nathan Bossart <nathandbossart@gmail.com>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Christophe Pettus <xof@thebuild.com>
Cc: vaibhave postgres <postgresvaibhave@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Noah Misch <noah@leadboat.com>
Cc: pgsql-bugs@lists.postgresql.org
Cc: vsekar@microsoft.com
Subject: Re: vacuumdb: permission denied for schema "pg_temp_7"
Date: Tue, 24 Sep 2024 09:51:14 -0500
Message-ID: <ZvLR4u3CVcN03z0o@nathan> (raw)
In-Reply-To: <ffefcf03-41fe-400b-929b-90692eb70e44@oss.nttdata.com>
References: <2603142.1726873660@sss.pgh.pa.us>
<5f37ee56-14fb-44fe-9150-9eb97e10538b@oss.nttdata.com>
<2649165.1726898595@sss.pgh.pa.us>
<CAM_eQjyWnu_LUt6JWjh3boNFHAT9DBrcbamhG3Xy39Q4Ph=2rg@mail.gmail.com>
<ZvGye19tHrhLCpFl@nathan>
<E9660D68-5B26-488E-9AB2-2CA1E8EDDDA1@thebuild.com>
<ZvIRG6282T33q3Ku@paquier.xyz>
<00d98a9f-bec1-4cd0-b59e-1043ae04c8bc@oss.nttdata.com>
<ZvLMDXv1XrxuJfT3@nathan>
<ffefcf03-41fe-400b-929b-90692eb70e44@oss.nttdata.com>
On Tue, Sep 24, 2024 at 11:49:12PM +0900, Fujii Masao wrote:
> On 2024/09/24 23:26, Nathan Bossart wrote:
>> Yeah, this is what I mentioned upthread [0]. If the user doesn't specify
>> anything in --table or --schema, then it's probably fine to silently skip
>> objects for which they lack privileges. But if they do explicitly specify
>> a table or schema that they cannot vacuum, then IMHO it'd be better to
>> fail.
>
> This could be debatable. To be honest, if I run something like vacuumdb mydb,
> *I* expect all eligible tables in that database to be vacuumed. If I forget to
> grant the necessary privileges to the role, I´d prefer to see errors from
> vacuumdb so I can fix the permissions.
>
> If we decide to skip tables without enough privilege, I´d prefer adding
> an option like --skip-unprivileged-tables rather than changing the default behavior.
I'm okay with that approach.
--
nathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: nathandbossart@gmail.com, masao.fujii@oss.nttdata.com, michael@paquier.xyz, xof@thebuild.com, postgresvaibhave@gmail.com, tgl@sss.pgh.pa.us, noah@leadboat.com, pgsql-bugs@lists.postgresql.org, vsekar@microsoft.com
Subject: Re: vacuumdb: permission denied for schema "pg_temp_7"
In-Reply-To: <ZvLR4u3CVcN03z0o@nathan>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox