From: Michael Paquier <michael@paquier.xyz>
To: Jim Jones <jim.jones@uni-muenster.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-bugs@lists.postgresql.org
Cc: maralist86@mail.ru
Subject: Re: BUG #18943: Return value of a function 'xmlBufferCreate' is dereferenced at xpath.c:177 without checking for NUL
Date: Mon, 9 Jun 2025 07:27:56 +0900
Message-ID: <aEYObH2KRs_9WkB7@paquier.xyz> (raw)
In-Reply-To: <8109cb57-0628-4a47-bbdb-81990c7ce1fb@uni-muenster.de>
References: <aEEingzOta_S_Nu7@paquier.xyz>
<CAPLXN34Dr3Gbi+xJ6BgCeTyBJkMVe3cn7qxoADV72rC9ZHeBtQ@mail.gmail.com>
<d2410ca0-c0dd-4f63-9e70-3d7a62a5d705@uni-muenster.de>
<b35e2342-0f02-4365-94cf-55052ac9bda1@uni-muenster.de>
<aEKCoNIfLxjyKY3r@paquier.xyz>
<31f3480e-cd7d-4021-b392-87922572cc37@uni-muenster.de>
<aETzMep2fGfB0AIp@paquier.xyz>
<ccbc7e75-6ae7-4ec8-bff9-d6c4ce5dd42e@uni-muenster.de>
<182094.1749397211@sss.pgh.pa.us>
<8109cb57-0628-4a47-bbdb-81990c7ce1fb@uni-muenster.de>
On Sun, Jun 08, 2025 at 07:00:25PM +0200, Jim Jones wrote:
> On 08.06.25 17:40, Tom Lane wrote:
>> Our risk-aversion level rises steadily over the course of a release
>> cycle, and is pretty high post beta1. While I think the problems
>> we're trying to fix here are real, they are very low-probability
>> (I don't recall hearing any field reports traceable to this).
>> And you have to remember there is also some risk of introducing
>> new bugs. On balance it's not a change I would back-patch, and
>> at this point v18 is pretty close to being a stable branch so
>> it's not getting fixes we wouldn't back-patch, unless that's
>> because they are in new-in-18 code.
That's something that can be measured with a kind of risk/reward
ratio. Here is the reward for the end-user is low, as we have no
reports of the current code in the field. The risk is in introducing
new issues. And the code is incorrect, so we should fix it.
I've made similar choices in the past around the same time in the
release cycle not backpatching stuff that was an issue in backbranches
still minimal enough to not have to worry about, like 84e4570da923
(there are a few others).
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../aEYObH2KRs_9WkB7@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: michael@paquier.xyz, jim.jones@uni-muenster.de, tgl@sss.pgh.pa.us, pgsql-bugs@lists.postgresql.org, maralist86@mail.ru
Subject: Re: BUG #18943: Return value of a function 'xmlBufferCreate' is dereferenced at xpath.c:177 without checking for NUL
In-Reply-To: <aEYObH2KRs_9WkB7@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox