public inbox for [email protected]  

help / color / mirror / Atom feed

From: Álvaro Herrera <[email protected]>
To: Никита Калинин <[email protected]>
Cc: [email protected]
Cc: Antonin Houska <[email protected]>
Subject: Re: BUG #19500: pgrepack logical decoding plugin can crash assert builds via SQL decoding API
Date: Tue, 2 Jun 2026 14:25:51 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

Hi Nikita,

On 2026-Jun-02, Никита Калинин wrote:

> > On 2 Jun 2026, at 00:12, Álvaro Herrera <[email protected]> wrote:

> But does the error message need to be that detailed? Perhaps something like
> 
> "ERROR: wrong magic number in "pgrepack" decoder plugin"
> would be sufficient.

Maybe.  Getting 0x00000000 would be quite different from 0x7f7f7f7f for
instance, or a completely random number, so I don't want to judge ahead
of time.

> Nevertheless, I tested the patch and can confirm that there are no
> assertion failures anymore. 
> 
> I also ran it under ASAN and did not observe any issues.

Thanks for testing it.

> Would it make sense to add a test for this case from the bug report?

Sure, I would do that.

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/
"Saca el libro que tu religión considere como el indicado para encontrar la
oración que traiga paz a tu alma. Luego rebootea el computador
y ve si funciona" (Carlos Duclós)

view thread (14+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: BUG #19500: pgrepack logical decoding plugin can crash assert builds via SQL decoding API
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox