public inbox for [email protected]  
help / color / mirror / Atom feed
From: Michael Paquier <[email protected]>
To: Xuneng Zhou <[email protected]>
Cc: Alexander Lakhin <[email protected]>
Cc: [email protected]
Subject: Re: BUG #18158: Assert in pgstat_report_stat() fails when a backend shutting down with stats pending
Date: Mon, 8 Jun 2026 14:48:55 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <CABPTF7XWsFgfAqqTv2epcMQs+vT6EMg_j43F8CSJ7Cjsv8QLJQ@mail.gmail.com>
References: <[email protected]>
	<[email protected]>
	<CABPTF7XdDoLAoLKo7pOHmSqHniHf46Pw8Z=iqNx2uYi4J5ixBA@mail.gmail.com>
	<[email protected]>
	<CABPTF7VgzdBP_ZPKf2eZ79ry0fVKzcgCkB5gy60HGXCy0EQb0w@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CABPTF7XWsFgfAqqTv2epcMQs+vT6EMg_j43F8CSJ7Cjsv8QLJQ@mail.gmail.com>

On Sat, Jun 06, 2026 at 08:45:26PM +0800, Xuneng Zhou wrote:
> Sorry for being late. One nit for the patch -- would it be better to
> use AmWalSenderProcess() for identification to save the include?
> +#include "replication/walsender.h"

In the startup sequence, MyBackendType is updated to B_WAL_SENDER a
couple of lines after am_walsender.  One or the other don't really
matter; they're both right.
--
Michael


Attachments:

  [application/pgp-signature] signature.asc (833B, 2-signature.asc)
  download

view thread (12+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: BUG #18158: Assert in pgstat_report_stat() fails when a backend shutting down with stats pending
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox