pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: shihao zhong <zhong950419@gmail.com>
Cc: Tomas Vondra <tomas@vondra.me>
Cc: 1217816127@qq.com, pgsql-bugs@lists.postgresql.org, PG Bug reporting form <noreply@postgresql.org>
Subject: Re: BUG #19763: ManualBug2 NULL pointer dereference in make_build_data via examine_expression bypass of lookup_var_a
Date: Fri, 30 Oct 2026 17:41:20 +0900
Message-ID: <auRYMA9y5QQkx2_e@paquier.xyz> (raw)
In-Reply-To: <CAGRkXqSiF1Ng=ppqEZqW0NUMu_AeyN9aaHHe98CfY97_uFeavA@mail.gmail.com>
References: <19763-14da3f96c02f07e8@postgresql.org>
	<d6cc3cd3-4eea-45a1-a2e4-91423a902063@vondra.me>
	<4a008244-3d3f-4563-8caf-0976fc59816f@vondra.me>
	<CAGRkXqTTTYgav5f5SRdoMVBc50rmx+L8rwdb38i+qdaixuN1qg@mail.gmail.com>
	<atcUe6vjUEn_K9vu@paquier.xyz>
	<CAGRkXqQWF+p5O46uh-4aRQQr5135RZr=91UArf+eijOaUv1JCw@mail.gmail.com>
	<athUGX48bWpMkGjP@paquier.xyz>
	<CAGRkXqTQUgA4O9JjJnOitbGRXzMhK9O8XMaFpoyoXbDOpNRtuQ@mail.gmail.com>
	<atmPcXaQykv09GMu@paquier.xyz>
	<CAGRkXqSiF1Ng=ppqEZqW0NUMu_AeyN9aaHHe98CfY97_uFeavA@mail.gmail.com>

On Thu, Oct 22, 2026 at 09:17:59PM -0400, shihao zhong wrote:
> Thanks. v4 shortens the comments on both callbacks and in the tests,
> and makes report_ext_stats_not_computed() static inline. Nothing else
> changed.

Thanks for the patch, and my apologies for the time it took to come
back here.  I have reworked the thing quite a bit, adjusting and
improving the code and comments, and applied it down to v14.  The
README of the test module also lacked an update.

Note that the test uses a check based on d.stxoid to see if there is
any data at all, which was stronger than your suggestion.  v14 has
kept the stxdexpr, though.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (11+ messages)

Message-ID: <auRYMA9y5QQkx2_e@paquier.xyz>
Permalink:  ../auRYMA9y5QQkx2_e@paquier.xyz/
Also on:    postgresql.org/message-id/auRYMA9y5QQkx2_e@paquier.xyz

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-bugs@postgresql.org
  Cc: michael@paquier.xyz, zhong950419@gmail.com, tomas@vondra.me, noreply@postgresql.org
  Subject: Re: BUG #19763: ManualBug2 NULL pointer dereference in make_build_data via examine_expression bypass of lookup_var_a
  In-Reply-To: <auRYMA9y5QQkx2_e@paquier.xyz>
  References: <19763-14da3f96c02f07e8@postgresql.org> <d6cc3cd3-4eea-45a1-a2e4-91423a902063@vondra.me> <4a008244-3d3f-4563-8caf-0976fc59816f@vondra.me> <CAGRkXqTTTYgav5f5SRdoMVBc50rmx+L8rwdb38i+qdaixuN1qg@mail.gmail.com> <atcUe6vjUEn_K9vu@paquier.xyz> <CAGRkXqQWF+p5O46uh-4aRQQr5135RZr=91UArf+eijOaUv1JCw@mail.gmail.com> <athUGX48bWpMkGjP@paquier.xyz> <CAGRkXqTQUgA4O9JjJnOitbGRXzMhK9O8XMaFpoyoXbDOpNRtuQ@mail.gmail.com> <atmPcXaQykv09GMu@paquier.xyz> <CAGRkXqSiF1Ng=ppqEZqW0NUMu_AeyN9aaHHe98CfY97_uFeavA@mail.gmail.com> <auRYMA9y5QQkx2_e@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox