pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
To: Zhijie Hou <houzhijie22@gmail.com>
Cc: Atisss hh <125atishprak@gmail.com>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #19839: Assert in ReorderBufferRestoreCleanup for aborted, spilled transaction
Date: Mon, 9 Nov 2026 14:47:17 +0000
Message-ID: <avHc9Z9u7Ns6xD43@bdtpg> (raw)
In-Reply-To: <ba2ec30c-e381-4422-913b-24afb4263fc8@gmail.com>
References: <19839-ead02c2208a3f8bd@postgresql.org>
	<CAGqfTtvQB4J0dJFnNMAF9LCAJhGBe5THd2R_=MxTHP5C5vwD=w@mail.gmail.com>
	<1da45744-968f-4f40-addf-dc085e928ec5@gmail.com>
	<avGmDSdgyIZB73Sl@bdtpg>
	<ba2ec30c-e381-4422-913b-24afb4263fc8@gmail.com>

Hi,

On Mon, Nov 09, 2026 at 07:46:59PM +0800, Zhijie Hou wrote:
> Thanks for the review. It looks like Atisss's update patches didn't reach
> the list, probably a missing Reply-All, so I'm helping to attach the same
> patches (provided by Atisss) here.

LGTM, just one nit about:

+		/*
+		 * Mark the transaction as serialized only if something was written,
+		 * and only after the check above.  final_lsn is advanced for each
+		 * change written, so a transaction that wrote nothing, such as a
+		 * subtransaction without decoded changes, would be marked with an
+		 * invalid final_lsn, and ReorderBufferRestoreCleanup() would later
+		 * fail on it.
+		 */


It looks lengthy and “the check above” is ambiguous. I'm not sure we need a new
comment here, maybe just replace the existing?

/* update the statistics iff we have spilled anything */

with

/* update the statistics and mark the transaction serialized iff we spilled */


Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com






view thread (7+ messages)  latest in thread

Message-ID: <avHc9Z9u7Ns6xD43@bdtpg>
Permalink:  ../avHc9Z9u7Ns6xD43@bdtpg/
Also on:    postgresql.org/message-id/avHc9Z9u7Ns6xD43@bdtpg

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-bugs@postgresql.org
  Cc: bertranddrouvot.pg@gmail.com, houzhijie22@gmail.com, 125atishprak@gmail.com
  Subject: Re: BUG #19839: Assert in ReorderBufferRestoreCleanup for aborted, spilled transaction
  In-Reply-To: <avHc9Z9u7Ns6xD43@bdtpg>
  References: <19839-ead02c2208a3f8bd@postgresql.org> <CAGqfTtvQB4J0dJFnNMAF9LCAJhGBe5THd2R_=MxTHP5C5vwD=w@mail.gmail.com> <1da45744-968f-4f40-addf-dc085e928ec5@gmail.com> <avGmDSdgyIZB73Sl@bdtpg> <ba2ec30c-e381-4422-913b-24afb4263fc8@gmail.com> <avHc9Z9u7Ns6xD43@bdtpg>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox