pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Corey Huinker <corey.huinker@gmail.com>
Cc: pgsql-bugs@lists.postgresql.org
Cc: 125atishprak@gmail.com
Subject: Re: BUG #19857: Stats restore rejects empty arrays, losing range and array stats
Date: Thu, 12 Nov 2026 07:40:47 +0900
Message-ID: <avTu757_g0z96QA2@paquier.xyz> (raw)
In-Reply-To: <CADkLM=fB1qJJZswCzSs7M=fG3ayXn8hdHy2a6vsAcrgVMVNY-w@mail.gmail.com>
References: <19857-6e808a09ff4b75d2@postgresql.org>
	<CADkLM=dgnnbdMF3T4Him9O+h+-_MArPzZ13SMm4g8LpAXAqmeQ@mail.gmail.com>
	<CADkLM=eyZKWTwFYh=Yyi-zqQwmkdZyVJaUD0tijoBZr=OTkFeQ@mail.gmail.com>
	<CADkLM=fo1+1LwJo2Jbi3S-MS--4257Q9gA9Pt6tWhwFzzPh8Sg@mail.gmail.com>
	<avQcPMvpFykeUGli@paquier.xyz>
	<CADkLM=fB1qJJZswCzSs7M=fG3ayXn8hdHy2a6vsAcrgVMVNY-w@mail.gmail.com>

On Wed, Nov 11, 2026 at 08:46:56AM -0500, Corey Huinker wrote:
> Nitpick: I think the error message itself needs to change based on
> allow_empty, as true allows 1-D or empty, and false allows only 1-D.

Yeah, point taken that this could be a little bit better, in a shape
similar to what you are suggesting.  I can see that we have similar
requirements in some of the array functions, though..  Will try to
shape that this way.

> This way seems not invasive at all, so I like it better.

Okay, noted.

> I'll redo the ext stats patchset to this pattern. Do you intend to commit
> this soon? Asking so I know whether to rebase-away the 0001 patch.

Yeah, I intend to wrap this one this morning.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (13+ messages)  latest in thread

Message-ID: <avTu757_g0z96QA2@paquier.xyz>
Permalink:  ../avTu757_g0z96QA2@paquier.xyz/
Also on:    postgresql.org/message-id/avTu757_g0z96QA2@paquier.xyz

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-bugs@postgresql.org
  Cc: michael@paquier.xyz, corey.huinker@gmail.com, 125atishprak@gmail.com
  Subject: Re: BUG #19857: Stats restore rejects empty arrays, losing range and array stats
  In-Reply-To: <avTu757_g0z96QA2@paquier.xyz>
  References: <19857-6e808a09ff4b75d2@postgresql.org> <CADkLM=dgnnbdMF3T4Him9O+h+-_MArPzZ13SMm4g8LpAXAqmeQ@mail.gmail.com> <CADkLM=eyZKWTwFYh=Yyi-zqQwmkdZyVJaUD0tijoBZr=OTkFeQ@mail.gmail.com> <CADkLM=fo1+1LwJo2Jbi3S-MS--4257Q9gA9Pt6tWhwFzzPh8Sg@mail.gmail.com> <avQcPMvpFykeUGli@paquier.xyz> <CADkLM=fB1qJJZswCzSs7M=fG3ayXn8hdHy2a6vsAcrgVMVNY-w@mail.gmail.com> <avTu757_g0z96QA2@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox