From: Jonathan S. Katz <jkatz@postgresql.org>
To: Daniel Gustafsson <daniel@yesql.se>
To: Gurjeet Singh <gurjeet@singh.im>
Cc: johnlinp@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Cc: pgsql-www@postgresql.org
Subject: Re: BUG #18018: Homebrew link is broken
Date: Wed, 12 Jul 2023 09:45:20 -0400
Message-ID: <b919b37b-6e36-02c9-b554-46b0c4d2e0fe@postgresql.org> (raw)
In-Reply-To: <2F054C6F-288B-4CB1-9EF2-4E11DB98397D@yesql.se>
References: <18018-016a323e1947b6f5@postgresql.org>
<CABwTF4UfTHRMnTkAw_JBh3eunPSnhxoAQVOzms+Uf81OtuUfWA@mail.gmail.com>
<2F054C6F-288B-4CB1-9EF2-4E11DB98397D@yesql.se>
On 7/12/23 8:49 AM, Daniel Gustafsson wrote:
>> On 11 Jul 2023, at 20:14, Gurjeet Singh <gurjeet@singh.im> wrote:
>> On Tue, Jul 11, 2023 at 3:29 AM PG Bug reporting form
>> <noreply@postgresql.org> wrote:
>
>>>> A list of PostgreSQL packages can be found using the Braumeister search
>>> tool.
>>>
>>> And the link is https://formulae.brew.sh/formula/postgresql.
>>>
>>> However, the link is broken. Please consider changing the link. Thanks.
>>
>> Homebrew does not (no longer?) provides a formula named postgresql;
>> instead, it provides a formula for each of the Postgres major
>> versions.
>
>> Perhaps this webpage can provide the brew command to list available
>> formulae, and advise to install one from the result.
>
> I'm not sure it's worth complicating this too much, including brew commands
> means we need to keep up with brew development to make they are still relevant.
We do include commands for other installed (dnf/yum; apt), and we do
provide commands (albeit generic) for installing from some of the
distros (see "Included in Distribution").
> Since the package page for the postgresql15 package lists all the other
> postgresqlXX packages available, why not just link to that (changing it to @16
> when that's available on brew)? The page also doesn't say Braumeister
> anywhere, so we should perhaps change that while at it?
>
> The attached small diff updates the link with the above. Thoughts?
I don't agree in its entirety. We say we're linking to a "list" of
PostgreSQL downloads, but it's linking to "latest" (which includes a
list of older packages). Additionally, given the way it's structured,
we'd have to update it for every major release anyway, so we may as well
list out the command if we're going to keep showing Homebrew on the
downloads page.
Attached is a revision of your patch.
Thanks,
Jonathan
[1] https://www.postgresql.org/download/linux/redhat/Attachments:brew_link_v2.diff (text/plain, 1.3K) downloaddiff --git a/templates/pages/download/macosx.html b/templates/pages/download/macosx.htmlindex fec5670..6cf6c67 100644--- a/templates/pages/download/macosx.html+++ b/templates/pages/download/macosx.html@@ -93,15 +93,23 @@ ready and awaiting new connections. Close the app, and the server shuts down.
<h2>Homebrew</h2>
<p>
-PostgreSQL can also be installed on macOS-using <a href="https://brew.sh">Homebrew</a>. Please see the Homebrew-documentation for information on how to install packages.+PostgreSQL can also be installed on macOS using+<a href="https://brew.sh">Homebrew</a>. For example, to install PostgreSQL 15,+you can use the following command:
</p>
<p>
-A list-of <a href="https://formulae.brew.sh/formula/postgresql">PostgreSQL-packages</a> can be found using the Braumeister search tool.+ <code>+ brew install postgresql@15+ </code>+</p>++<p>+ You can use <a href="https://formulae.brew.sh">Homebrew Formulae</a> to+ search for PostgreSQL and other packages. To find a specific major version of+ PostgreSQL, search for <code>postgresql@NN</code>, where <code>NN</code>+ represents the major version. For example,+ <a href="https://formulae.brew.sh/formula/postgresql@15"><code>postgresql@15</code></a>.
</p>
<h2>MacPorts</h2>
OpenPGP_signature (application/pgp-signature, 839B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: jkatz@postgresql.org, daniel@yesql.se, gurjeet@singh.im, johnlinp@gmail.com, pgsql-bugs@lists.postgresql.org, pgsql-www@postgresql.org
Subject: Re: BUG #18018: Homebrew link is broken
In-Reply-To: <b919b37b-6e36-02c9-b554-46b0c4d2e0fe@postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox