From: Jesper Pedersen <jesper.pedersen@redhat.com>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15587: Partitions with ALTER TABLE ADD CONSTRAINT
Date: Tue, 15 Jan 2019 14:45:03 -0500
Message-ID: <be81b47a-c6ae-b88e-54d9-06ab4298a5de@redhat.com> (raw)
In-Reply-To: <201901151935.zfadrzvyof4k@alvherre.pgsql>
References: <201901151935.zfadrzvyof4k@alvherre.pgsql>
Hi,
On 1/15/19 2:35 PM, Alvaro Herrera wrote:
> On 2019-Jan-15, Tom Lane wrote:
>> Alvaro Herrera <alvherre@2ndquadrant.com> writes:
>>> I haven't investigated this angle. It seems more complex than just a
>>> simple bugfix, right?
>>
>> Wouldn't that be throwing away the entire point of the ONLY behavior,
>> ie to allow the component indexes to be built one at a time, without
>> holding locks across the whole partition tree?
>
> I now see that Jesper was talking about a completely different thing
> than I was thinking. I agree with you there -- it makes no sense to
> reject that command ... particularly because pg_dump uses it.
>
I now think Tom is correct that it is UX and documentation issue, and
changing the existing behavior is probably not a good thing.
Changing "invalid" to "incomplete" would be a good idea. Maybe "partial"
could be a good descriptor if not all partitions shares the unique
constraint.
Best regards,
Jesper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: jesper.pedersen@redhat.com, alvherre@2ndquadrant.com, tgl@sss.pgh.pa.us, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15587: Partitions with ALTER TABLE ADD CONSTRAINT
In-Reply-To: <be81b47a-c6ae-b88e-54d9-06ab4298a5de@redhat.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox