From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Jehan-Guillaume de Rorthais <jgdr@dalibo.com>
To: pgsql-bugs@lists.postgresql.org
Cc: Michael Paquier <michael@paquier.xyz>
Subject: Re: [BUG] non archived WAL removed during production crash recovery
Date: Wed, 1 Apr 2020 17:27:22 +0900
Message-ID: <d0ef12c5-7e36-b9b3-c8ea-2e98d69d1317@oss.nttdata.com> (raw)
In-Reply-To: <20200331172229.40ee00dc@firost>
References: <20200331172229.40ee00dc@firost>
On 2020/04/01 0:22, Jehan-Guillaume de Rorthais wrote:
> Hello,
>
> A colleague of mine reported an expected behavior.
>
> On production cluster is in crash recovery, eg. after killing a backend, the
> WALs ready to be archived are removed before being archived.
>
> See in attachment the reproduction script "non-arch-wal-on-recovery.bash".
>
> This behavior has been introduced in 78ea8b5daab9237fd42d7a8a836c1c451765499f.
> Function XLogArchiveCheckDone() badly consider the in crashed recovery
> production cluster as a standby without archive_mode=always. So the check
> conclude the WAL can be removed safely.
Thanks for the report! Yeah, this seems a bug.
> bool inRecovery = RecoveryInProgress();
>
> /*
> * The file is always deletable if archive_mode is "off". On standbys
> * archiving is disabled if archive_mode is "on", and enabled with
> * "always". On a primary, archiving is enabled if archive_mode is "on"
> * or "always".
> */
> if (!((XLogArchivingActive() && !inRecovery) ||
> (XLogArchivingAlways() && inRecovery)))
> return true;
>
> Please find in attachment a patch that fix this issue using the following test
> instead:
>
> if (!((XLogArchivingActive() && !StandbyModeRequested) ||
> (XLogArchivingAlways() && inRecovery)))
> return true;
>
> I'm not sure if we should rely on StandbyModeRequested for the second part of
> the test as well thought. What was the point to rely on RecoveryInProgress() to
> get the recovery status from shared mem?
Since StandbyModeRequested is the startup process-local variable,
it basically cannot be used in XLogArchiveCheckDone() that other process
may call. So another approach would be necessary... One straight idea is to
add new shmem flag indicating whether we are in standby mode or not.
Another is to make the startup process remove .ready file if necessary.
If it's not easy to fix the issue, we might need to just revert the commit
that introduced the issue at first.
Regards,
--
Fujii Masao
NTT DATA CORPORATION
Advanced Platform Technology Group
Research and Development Headquarters
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: masao.fujii@oss.nttdata.com, jgdr@dalibo.com, pgsql-bugs@lists.postgresql.org, michael@paquier.xyz
Subject: Re: [BUG] non archived WAL removed during production crash recovery
In-Reply-To: <d0ef12c5-7e36-b9b3-c8ea-2e98d69d1317@oss.nttdata.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox