From: Alexander Lakhin <exclusion@gmail.com>
To: shihao zhong <zhong950419@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Tomas Vondra <tomas.vondra@enterprisedb.com>
Cc: pgsql-bugs@lists.postgresql.org, Masahiko Sawada <sawada.mshk@gmail.com>
Subject: Re: BUG #17969: Assert failed in bloom_init() when false_positive_rate = 0.25
Date: Tue, 24 Oct 2023 16:00:00 +0300
Message-ID: <e28ce947-4755-41cf-1460-4b92f4fbdc3a@gmail.com> (raw)
In-Reply-To: <CAGRkXqSHB9aGTgHf0LPnv3ppMDA1iKxsZagyB3G+Drs5Tx7aZA@mail.gmail.com>
References: <17969-a6c54de48026d694@postgresql.org>
<836412.1686502986@sss.pgh.pa.us>
<CAD21AoANsYnyHHSK543e1mFwuRBsVATs-Z0RnrE9thqaSsWZbA@mail.gmail.com>
<2322240.1686882232@sss.pgh.pa.us>
<5540898f-706c-f399-2797-9e8fa58a5d81@gmail.com>
<CAGRkXqSHB9aGTgHf0LPnv3ppMDA1iKxsZagyB3G+Drs5Tx7aZA@mail.gmail.com>
Hi Shihao,
23.10.2023 23:58, shihao zhong wrote:
> Hi Alexander,
>
> This change makes sense to me. But I have a question here, because we already have a limitation in rel option level
> and that will make sure the parameter is in 0.0001 - 0.25 range, this CHECK seems like a little redundant for me
> especially it does not match the constraint in rel option. Maybe I missed some context here, but could we just remove
> this CHECK?
I had started this discussion with the same question, but Tom Lane proposed
to reformulate the Assert [1] and I agree that it's for good.
Index attribute options are checked when an index created, but then
attoptions can be changed in pg_attribute, for example. I mean that such
a check makes sense because there is an intermediate level between setting
the option and using it.
[1] https://www.postgresql.org/message-id/836412.1686502986%40sss.pgh.pa.us
Best regards,
Alexander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: exclusion@gmail.com, zhong950419@gmail.com, tgl@sss.pgh.pa.us, tomas.vondra@enterprisedb.com, sawada.mshk@gmail.com
Subject: Re: BUG #17969: Assert failed in bloom_init() when false_positive_rate = 0.25
In-Reply-To: <e28ce947-4755-41cf-1460-4b92f4fbdc3a@gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox