pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alexander Lakhin <exclusion@gmail.com>
To: ocean_li_996 <ocean_li_996@163.com>
Cc: pgsql-bugs@lists.postgresql.org, Amit Kapila <amit.kapila16@gmail.com>
Subject: Re: BUG #18369: logical decoding core on AssertTXNLsnOrder()
Date: Thu, 29 Feb 2024 13:00:00 +0300
Message-ID: <e8236368-6b2b-6b76-a0c1-a064523a8f2c@gmail.com> (raw)
In-Reply-To: <3900f282.3f49.18df2ae796a.Coremail.ocean_li_996@163.com>
References: <18369-ad61699bf91c5bc0@postgresql.org>
	<6d0e80d6.c1fc.18deeb8120a.Coremail.ocean_li_996@163.com>
	<3d696d51.cfa6.18deeccd483.Coremail.ocean_li_996@163.com>
	<c79e5171-cce8-9bd7-9578-5b3a440361f9@gmail.com>
	<3900f282.3f49.18df2ae796a.Coremail.ocean_li_996@163.com>

Hi Haiyang,

29.02.2024 05:25, ocean_li_996 wrote:
> > With your patch applied (on REL_14_STABLE) I still get:
> > TRAP: FailedAssertion("builder->next_phase_at == InvalidTransactionId", File: "snapbuild.c", Line: 1623, PID: 92772)
> >
> > when running make -s installcheck-force -C contrib/test_decoding...
> > as specified in that message.
> > (You might need to disable REGRESS tests in the Makefile to reach
> > isolation tests.)
> I'm not sure if I fully get your mind. I disabled the REGRESS tests in the test_decoding/Makefile and then manually 
> run the command "make -s installcheck-force -C contrib/test_decoding" a few times. I didn't encounter the issue you 
> mentioned. Is this problem consistently reproducible in your environment? BTW, the  issue mentioned in [1] is more 
> similar to your problem. And the patch was not applied to v14.  Maybe it is another issue.
>

You can try the following script (assuming a server with the test_decoding
module installed is running):
rm -rf contrib/test_decoding_*
numclients=5
for ((c=1;c<=numclients;c++)); do
    cp -r contrib/test_decoding contrib/test_decoding_$c
    sed "s/REGRESS = /# REGRESS =/" -i contrib/test_decoding_$c/Makefile
    sed "s/isolation_slot/isolation_slot_$c/" -i contrib/test_decoding_$c/specs/catalog_change_snapshot.spec # Use 
independent slots
    sed "$(printf '$p; %.0s' `seq 50`)" -i contrib/test_decoding_$c/specs/catalog_change_snapshot.spec # Repeat the last 
permutation 50 times
done
for ((c=1;c<=numclients;c++)); do
    EXTRA_REGRESS_OPTS="--dbname=regress_$c" make -s installcheck-force -C contrib/test_decoding_$c USE_MODULE_DB=1 
 >"installcheck-$c.log" 2>&1 &
done
wait

Though that's really not directly related to the current issue (sorry for
the wrong direction, my point was that there are still living bugs in this
area).

I've found that your added test case fails on REL_15_STABLE starting from
b793a416b (6b77048e5 on REL_14_STABLE), so it looks like this is a new
defect introduced in REL_14_STABLE, REL_15_STABLE recently with the fix for
bug #18280.

As to REL_13_STABLE/REL_12_STABLE the failure reproduced starting from
commits 38dbaaf27/02600886c, a result of the aforementioned discussion:
https://www.postgresql.org/message-id/CAA4eK1Lx%3Dg09z2k9Teq9ca1eRzfpfxJwFdjyHNwgEKv69KWhrQ%40mail.g...

Best regards,
Alexander

view thread (32+ messages)  latest in thread

Message-ID: <e8236368-6b2b-6b76-a0c1-a064523a8f2c@gmail.com>
Permalink:  ../e8236368-6b2b-6b76-a0c1-a064523a8f2c@gmail.com/
Also on:    postgresql.org/message-id/e8236368-6b2b-6b76-a0c1-a064523a8f2c@gmail.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: exclusion@gmail.com, ocean_li_996@163.com, amit.kapila16@gmail.com
  Subject: Re: BUG #18369: logical decoding core on AssertTXNLsnOrder()
  In-Reply-To: <e8236368-6b2b-6b76-a0c1-a064523a8f2c@gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox