From: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
To: fedor_erastov@mail.ru
Cc: pgsql-bugs@lists.postgresql.org, Andres Freund <andres@anarazel.de>
Subject: Re: BUG #16644: null value for defaults in OLD variable for trigger
Date: Wed, 30 Sep 2020 13:02:39 -0400
Message-ID: <ee18ae40-ca29-4a17-259e-3f7ff6461f00@2ndQuadrant.com> (raw)
In-Reply-To: <802555.1601432494@sss.pgh.pa.us>
References: <16644-5da7ef98a7ac4545@postgresql.org>
<802555.1601432494@sss.pgh.pa.us>
On 9/29/20 10:21 PM, Tom Lane wrote:
>
> If you ask me, the proximate cause of this bug was the decision
> to stick attrmissing info into the "constr" field of tupledescs.
> That seems pretty damfool, because there are large parts of the
> system that consider that the constr info is optional and can
> be discarded, or never built to begin with. Perhaps it's too late
> to revisit that, but we need to take a very very hard look at an
> awful lot of places if we're to stick with that design.
>
:-(
At nearly three years remove my memory is a bit hazy, but IIRC I looked
at all the places (or all I could identify) where it might have mattered
and it looked OK. But I'm not going to bet my life I caught everything,
and maybe I unintentionally provided for a future footgun, which from
your description this appears to be.
I'm not sure what the implications of changing it would be.
cheers
andrew
--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: andrew.dunstan@2ndquadrant.com, tgl@sss.pgh.pa.us, fedor_erastov@mail.ru, andres@anarazel.de
Subject: Re: BUG #16644: null value for defaults in OLD variable for trigger
In-Reply-To: <ee18ae40-ca29-4a17-259e-3f7ff6461f00@2ndQuadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox