From: Heikki Linnakangas <hlinnaka@iki.fi>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alexander Lakhin <exclusion@gmail.com>
Cc: PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #17064: Parallel VACUUM operations cause the error "global/pg_filenode.map contains incorrect checksum"
Date: Thu, 24 Jun 2021 11:31:01 +0300
Message-ID: <f0d05962-9058-b583-706c-af1c788fc3cb@iki.fi> (raw)
In-Reply-To: <CA+hUKGLev=PpOSaL3WRZgOvgk217et+bxeJcRr4eR-NttP1F6Q@mail.gmail.com>
References: <17064-bb0d7904ef72add3@postgresql.org>
<ac119d1e-05d1-f050-b92a-0a524d68b848@iki.fi>
<CA+hUKGJ98=MOjDCnMAC5gSpkzrrey=O+aEQJ1OY03C=cVtiwkA@mail.gmail.com>
<1715251.1624371066@sss.pgh.pa.us>
<CA+hUKGKKgJbFycOfr6JTBLp_A-zKY1Ow8zndB6qjwSJpw7Yzgg@mail.gmail.com>
<f03d9166-ad12-2a3c-f605-c1873ee86ae4@iki.fi>
<CA+hUKGJg341Rf1zD3Rh3vXUbs_bP+LuOiT-Juj+nOWVr1QUkBg@mail.gmail.com>
<19190f79-cf37-ff18-1b40-07a1a66a1d9e@iki.fi>
<CA+hUKGLev=PpOSaL3WRZgOvgk217et+bxeJcRr4eR-NttP1F6Q@mail.gmail.com>
On 24/06/2021 11:06, Thomas Munro wrote:
> On Thu, Jun 24, 2021 at 7:52 PM Heikki Linnakangas <hlinnaka@iki.fi> wrote:
>> On 23/06/2021 12:45, Thomas Munro wrote:
>>> On Wed, Jun 23, 2021 at 7:46 PM Heikki Linnakangas <hlinnaka@iki.fi> wrote:
>>>> Let's just add the lock there.
>>>
>>> +1, no doubt about that.
>>
>> Committed that. Thanks for the report, Alexander!
>
> I think you missed relmap_redo (including a misleading comment).
Fixed, thanks!
>> If anyone wants a write a patch for that, I'd be happy to review it. And
>> if anyone has access to a system with pmem hardware, it would be
>> interesting to try to reproduce a torn sector and broken control file by
>> pulling the power plug.
>
> I have been working on a kind of experimental file system for
> simulating torn sectors (and other interesting file system phenomena)
> as part of some work on recovery scenerio testing, not quite ready to
> share yet but it can simulate that exact failure...
Cool! We know what happens if pg_control file is torn, though. What I'd
like to know is whether it can happen in practice with pmem, an how
likely it is. For curiosity mostly, I think we have already established
that it can happen, and it would be nice to protect against it in any
case, even if it's rare.
- Heikki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: hlinnaka@iki.fi, thomas.munro@gmail.com, tgl@sss.pgh.pa.us, exclusion@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17064: Parallel VACUUM operations cause the error "global/pg_filenode.map contains incorrect checksum"
In-Reply-To: <f0d05962-9058-b583-706c-af1c788fc3cb@iki.fi>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox