From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Michael Paquier <michael@paquier.xyz>
To: Anthonin Bonnefoy <anthonin.bonnefoy@datadoghq.com>
Cc: Dilip Kumar <dilipbalaut@gmail.com>
Cc: a.kozhemyakin@postgrespro.ru
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18947: TRAP: failed Assert("len_to_wrt >= 0") in pg_stat_statements
Date: Wed, 11 Jun 2025 07:57:19 +0900
Message-ID: <f7d8ac5e-96f2-46ef-ba56-9e211f4ffc18@oss.nttdata.com> (raw)
In-Reply-To: <aEi0N9AmJnrFC6Ug@paquier.xyz>
References: <18947-cdd2668beffe02bf@postgresql.org>
<CAFiTN-tGux5MZ9Hk2wKv5sVhk7eDq2AHaT79LxnQbVamxoRn9Q@mail.gmail.com>
<aET38DIyBht33bIP@paquier.xyz>
<9171ecda-e1f4-4390-ae54-98bc441b98e3@oss.nttdata.com>
<aEfGl9bNPR5C76W2@paquier.xyz>
<CAO6_Xqoxsm_Y5dxc_4YmrhRACTBe-Y8Q=PP6Xv-svo6eud1-Mg@mail.gmail.com>
<aEgToLnBX9W43ne-@paquier.xyz>
<aEi0N9AmJnrFC6Ug@paquier.xyz>
On 2025/06/11 7:39, Michael Paquier wrote:
> On Tue, Jun 10, 2025 at 08:14:40PM +0900, Michael Paquier wrote:
>> Hmm. I am wondering whether this would be enough; these are not the
>> only places where we use select_no_parens and select_with_parens. I'd
>> be curious to see what you think a fully-bloomed fix should look like.
>
> By the way, this report also means that none of the problematic query
> patterns are run in the main regression test suite, or we would have
> noticed something immediately when running the recovery test
> 027_stream_regress.pl that loads PGSS.
>
> So we have a problem in test coverage with query normalization
> patterns. But we also have a second, older, problem in terms of
> coverage regarding the parentheses patterns that are assumed as
> supported in the parser. Even if we finish by reverting the nested
> query tracking support for now (let's settle things before beta2 not
> after it), we should definitely improve the main regression test suite
> in this area to make sure that reintroducing it safe.
Sounds reasonable to me.
Also I agree with reverting the commit and revisiting the feature in v19.
Regards,
--
Fujii Masao
NTT DATA Japan Corporation
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: masao.fujii@oss.nttdata.com, michael@paquier.xyz, anthonin.bonnefoy@datadoghq.com, dilipbalaut@gmail.com, a.kozhemyakin@postgrespro.ru, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18947: TRAP: failed Assert("len_to_wrt >= 0") in pg_stat_statements
In-Reply-To: <f7d8ac5e-96f2-46ef-ba56-9e211f4ffc18@oss.nttdata.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox