From: Vladlen Popolitov <v.popolitov@postgrespro.ru>
To: pgsql-bugs@lists.postgresql.org
Subject: Error in form on site commitfest.postgresql.org
Date: Thu, 13 Feb 2025 19:46:41 +0700
Message-ID: <ff6853183ac7d25acf2451d5eea7f6a5@postgrespro.ru> (raw)
Hi!
I do not know, who supports commitfest site, it why I am writing here.
Every time I add my review in commit fest, I see wrong form -
not all field in form are visible, see attached picture.
As result review generate wrong misleading text, that tests are failed,
like this from my last review:
The following review has been posted through the commitfest application:
make installcheck-world: tested, failed
Implements feature: tested, failed
Spec compliant: tested, failed
Documentation: tested, failed
I tried Safari, Chrome on Mac, Chrome, Edge and Explorer on Windows -
the same result.
The reason: the field "Passed" under field "Tested" is not visible.
I suppose the problem in bootstrap classes. I tried to change them to
documented classes from Bootstrap 3 (as referenced in this page),
and form works.
The solution.
If change the :
<div id="id_review_installcheck" class="form-control"><div>
to
<div id="id_review_installcheck" class="container pull-left"><div>
<div id="id_review_implements" class="form-control"><div>
to
<div id="id_review_implements" class="container pull-left"><div>
<div id="id_review_spec" class="form-control"><div>
to
<div id="id_review_spec" class="container pull-left"><div>
<div id="id_review_doc" class="form-control"><div>
to
<div id="id_review_doc" class="container pull-left"><div>
And all checkbook should be changed from
<input type="checkbox" name="review_installcheck" value="0"
class="form-control" id="id_review_installcheck_0">
to
<input type="checkbox" name="review_installcheck" value="0"
class="form-check-input" id="id_review_installcheck_0">
for better presentation.
In this case all fields will be visible.
--
Best regards,
Vladlen Popolitov.
Attachments:add_review_flags.png (image/png, 35.7K) downloadview image
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: v.popolitov@postgrespro.ru, pgsql-bugs@lists.postgresql.org
Subject: Re: Error in form on site commitfest.postgresql.org
In-Reply-To: <ff6853183ac7d25acf2451d5eea7f6a5@postgrespro.ru>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox