pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Subject: [PATCH v2 2/2] Remove obsolete comment in SnapBuildRestoreSnapshot()
Date: Tue, 4 Mar 2025 07:12:18 +0000

9ccdd7f66e3 invalidated this comment (that was present in SnapBuildRestore()
at that time. The initial meaning of it was that a critical section was not
necessary here.
---
 src/backend/replication/logical/snapbuild.c | 3 ---
 1 file changed, 3 deletions(-)
 100.0% src/backend/replication/logical/


inline patch 1: src/backend/replication/logical/snapbuild.c (+0/-3 lines) download inline-1.patchdiff --git a/src/backend/replication/logical/snapbuild.c b/src/backend/replication/logical/snapbuild.c
index b64e53de017..a53501f5316 100644
--- a/src/backend/replication/logical/snapbuild.c
+++ b/src/backend/replication/logical/snapbuild.c
@@ -1718,9 +1718,6 @@ SnapBuildRestoreSnapshot(SnapBuildOnDisk *ondisk, XLogRecPtr lsn,
 	/* ----
 	 * Make sure the snapshot had been stored safely to disk, that's normally
 	 * cheap.
-	 * Note that we do not need PANIC here, nobody will be able to use the
-	 * slot without fsyncing, and saving it won't succeed without an fsync()
-	 * either...
 	 * ----
 	 */
 	fsync_fname(path, false);
-- 
2.34.1



--7V3m2fno5VtGG8jS--





Message-ID: <no-message-id-25378@localhost>
Permalink:  ../no-message-id-25378@localhost/
Also on:    postgresql.org/message-id/no-message-id-25378@localhost

 ·  · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: bertranddrouvot.pg@gmail.com
  Subject: Re: [PATCH v2 2/2] Remove obsolete comment in SnapBuildRestoreSnapshot()
  In-Reply-To: <no-message-id-25378@localhost>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox