pg.ddx.io pgsql-bugs@postgresql.org mailing list archive
help / color / mirror / Atom feed[PATCH v2 2/2] Remove obsolete comment in SnapBuildRestoreSnapshot()
1+ messages / 1 participants
[nested] [flat]
* [PATCH v2 2/2] Remove obsolete comment in SnapBuildRestoreSnapshot()
@ 2025-03-04 07:12 Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
0 siblings, 0 replies; 1+ messages in thread
From: Bertrand Drouvot @ 2025-03-04 07:12 UTC (permalink / raw)
9ccdd7f66e3 invalidated this comment (that was present in SnapBuildRestore()
at that time. The initial meaning of it was that a critical section was not
necessary here.
---
src/backend/replication/logical/snapbuild.c | 3 ---
1 file changed, 3 deletions(-)
100.0% src/backend/replication/logical/
inline patch 1: src/backend/replication/logical/snapbuild.c (+0/-3 lines) download inline-1.patch
diff --git a/src/backend/replication/logical/snapbuild.c b/src/backend/replication/logical/snapbuild.c
index b64e53de017..a53501f5316 100644
--- a/src/backend/replication/logical/snapbuild.c
+++ b/src/backend/replication/logical/snapbuild.c
@@ -1718,9 +1718,6 @@ SnapBuildRestoreSnapshot(SnapBuildOnDisk *ondisk, XLogRecPtr lsn,
/* ----
* Make sure the snapshot had been stored safely to disk, that's normally
* cheap.
- * Note that we do not need PANIC here, nobody will be able to use the
- * slot without fsyncing, and saving it won't succeed without an fsync()
- * either...
* ----
*/
fsync_fname(path, false);
--
2.34.1
only message in thread
Thread overview: 1+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-03-04 07:12 [PATCH v2 2/2] Remove obsolete comment in SnapBuildRestoreSnapshot() Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox