pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Vallimaharajan <vallimaharajan.gs@zohocorp.com>
Subject: [PATCH] Skip partition immediately after run condition failure in WINDOWAGG_PASSTHROUGH_STRICT mode
Date: Wed, 13 Nov 2024 20:26:00 +0530

---
 src/backend/executor/nodeWindowAgg.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)


inline patch 1: src/backend/executor/nodeWindowAgg.c (+4/-2 lines) download inline-1.patchdiff --git a/src/backend/executor/nodeWindowAgg.c b/src/backend/executor/nodeWindowAgg.c
index 51a6708a39..ec13a9e030 100644
--- a/src/backend/executor/nodeWindowAgg.c
+++ b/src/backend/executor/nodeWindowAgg.c
@@ -2206,9 +2206,11 @@ ExecWindowAgg(PlanState *pstate)
 		 */
 		spool_tuples(winstate, winstate->currentpos);
 
-		/* Move to the next partition if we reached the end of this partition */
+		/* Move to the next partition if we reached the end of this partition or
+		 * if we are in STRICT pass-through mode */
 		if (winstate->partition_spooled &&
-			winstate->currentpos >= winstate->spooled_rows)
+			(winstate->currentpos >= winstate->spooled_rows ||
+			 winstate->status == WINDOWAGG_PASSTHROUGH_STRICT))
 		{
 			release_partition(winstate);
 
-- 
2.34.1



------=_Part_6447_1211805977.1731511331918
Content-Type: application/octet-stream; name=windowagg_fix2.patch
Content-Transfer-Encoding: 7bit
X-ZM_AttachId: 139508041319270000
Content-Disposition: attachment; filename=windowagg_fix2.patch



Message-ID: <no-message-id-25439@localhost>
Permalink:  ../no-message-id-25439@localhost/
Also on:    postgresql.org/message-id/no-message-id-25439@localhost

 ·  · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: vallimaharajan.gs@zohocorp.com
  Subject: Re: [PATCH] Skip partition immediately after run condition failure in WINDOWAGG_PASSTHROUGH_STRICT mode
  In-Reply-To: <no-message-id-25439@localhost>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox