pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: 1165125080 <1165125080@qq.com>
To: 1165125080 <1165125080@qq.com>
To: pgsql-bugs <pgsql-bugs@lists.postgresql.org>
Subject: RE:BUG #18533: pg_basebackup uses out-of-bounds memory and a segment error occurs during backup
Date: Wed, 17 Jul 2024 22:55:58 +0800
Message-ID: <tencent_D050F6EC2C1B44D0EA302D7C8447526DF208@qq.com> (raw)

> Do I think we should remove the bbstreamer_buffer_until call in the
> bbstreamer_tar_parser_content function in the scenario of
> BBFLOWER_MEMBER_TRAILER?


It might be more semantically appropriate to change the data in the bbstreamer_content function call to streamer->bbs_buffer


			case BBSTREAMER_MEMBER_TRAILER:
				if (!bbstreamer_buffer_until(streamer, &data, &len,
											 mystreamer->pad_bytes_expected))
					return;


				/* OK, now we can send it. */
				bbstreamer_content(mystreamer->base.bbs_next,
								   &mystreamer->member,
								   data, mystreamer->pad_bytes_expected,
								   BBSTREAMER_MEMBER_TRAILER);

Message-ID: <tencent_D050F6EC2C1B44D0EA302D7C8447526DF208@qq.com>
Permalink:  ../tencent_D050F6EC2C1B44D0EA302D7C8447526DF208@qq.com/
Also on:    postgresql.org/message-id/tencent_D050F6EC2C1B44D0EA302D7C8447526DF208@qq.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: 1165125080@qq.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: RE:BUG #18533: pg_basebackup uses out-of-bounds memory and a segment error occurs during backup
  In-Reply-To: <tencent_D050F6EC2C1B44D0EA302D7C8447526DF208@qq.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox