public inbox for [email protected]  

help / color / mirror / Atom feed

From: Heikki Linnakangas <[email protected]>
To: Bertrand Drouvot <[email protected]>
To: Álvaro Herrera <[email protected]>
Cc: Tomas Vondra <[email protected]>
Cc: Christoph Berg <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: Tomas Vondra <[email protected]>
Cc: [email protected]
Subject: Re: pgsql: Introduce pg_shmem_allocations_numa view
Date: Thu, 12 Feb 2026 19:42:20 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>

On 12/02/2026 19:23, Bertrand Drouvot wrote:
> Hi,
> 
> On Thu, Feb 12, 2026 at 05:43:47PM +0100, Álvaro Herrera wrote:
>> On 2026-Feb-12, Heikki Linnakangas wrote:
>>
>>> I just noticed that this (commit bf1119d74a: Add CHECK_FOR_INTERRUPTS into
>>> pg_numa_query_pages) made the function unusable in frontend programs,
>>> because CHECK_FOR_INTERRUPTS is server only.
> 
> Good catch! Out of curiosity how did you find the issue? Were you building a
> client tool making used of pg_numa_query_pages()?

I was working on my "interrupts vs signals" patch, which needed to 
change some #includes in pg_numa.c, when I spotted that it already had 
that issue.

>> It's not used in frontend
>>> programs today, but it was placed in src/port/ with the idea that it could
>>> be.
>>
>> Your patch LGTM.
> 
> +1

Pushed, thanks!

- Heikki

view thread (83+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: pgsql: Introduce pg_shmem_allocations_numa view
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox