From: Tomas Vondra <tomas.vondra@enterprisedb.com>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Tomas Vondra <tomas.vondra@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix skip-empty-xacts with sequences in test_decoding
Date: Mon, 14 Feb 2022 15:05:02 +0100
Message-ID: <0f39ab04-950e-d62f-b413-b07f1b8b36b9@enterprisedb.com> (raw)
In-Reply-To: <202202141336.xv35beswc6ec@alvherre.pgsql>
References: <202202141336.xv35beswc6ec@alvherre.pgsql>
On 2/14/22 14:36, Alvaro Herrera wrote:
> On 2022-Feb-13, Tomas Vondra wrote:
>
>>>> Fixing the tests however uncovered a bug in the code, because sequence
>>>> callbacks did not handle skip-empty-xacts properly. For trasactional
>>>> increments we need to check/update the xact_wrote_changes flag, and emit
>>>> the BEGIN if it's the first change in the transaction.
>>>
>>> Hmm. Perhaps there should be a separate test script that runs various
>>> things under skip-empty-xacts=0 and somehow protected against ancillary
>>> activities (maybe a TAP test using autovacuum=0), just so that this new
>>> code is covered ...
>>
>> I'm not sure what exactly would be the benefit?
>
> Yeah, it's pointless.
>
> I propose the attached comment additions instead.
>
The comments seem fine to me (although not really related to these
commits about sequence decoding).
regards
--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: tomas.vondra@enterprisedb.com, alvherre@alvh.no-ip.org, tomas.vondra@postgresql.org
Subject: Re: pgsql: Fix skip-empty-xacts with sequences in test_decoding
In-Reply-To: <0f39ab04-950e-d62f-b413-b07f1b8b36b9@enterprisedb.com>
References: <202202141336.xv35beswc6ec@alvherre.pgsql> <0f39ab04-950e-d62f-b413-b07f1b8b36b9@enterprisedb.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox