pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Replace random(), pg_erand48(), etc with a better PRNG API and a
Date: Sun, 28 Nov 2021 23:57:58 -0500
Message-ID: <1140657.1638161878@sss.pgh.pa.us> (raw)
In-Reply-To: <1135295.1638157668@sss.pgh.pa.us>
References: <E1mrWUD-000235-Hq@gemulon.postgresql.org>
	<1135295.1638157668@sss.pgh.pa.us>

I wrote:
> ... If so, we could perhaps
> fix it by doing

> #ifdef FRONTEND
> extern pg_prng_state pg_global_prng_state;
> #else
> extern PGDLLIMPORT pg_prng_state pg_global_prng_state;
> #endif

Ah, I now see the same hack being used in keywords.h and pg_bitutils.h,
so I'll go do that.  (Maybe we should invent a variant of PGDLLIMPORT
that can make this happen without as much code duplication?)

			regards, tom lane





view thread (3+ messages)

Message-ID: <1140657.1638161878@sss.pgh.pa.us>
Permalink:  ../1140657.1638161878@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1140657.1638161878@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andrew@dunslane.net
  Subject: Re: pgsql: Replace random(), pg_erand48(), etc with a better PRNG API and a
  In-Reply-To: <1140657.1638161878@sss.pgh.pa.us>
  References: <E1mrWUD-000235-Hq@gemulon.postgresql.org> <1135295.1638157668@sss.pgh.pa.us> <1140657.1638161878@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox