From: Tom Lane <tgl@sss.pgh.pa.us>
To: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: Jeff Davis <pgsql@j-davis.com>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix calculation of relid sets for partitionwise child joins.
Date: Sat, 22 Jul 2023 10:35:20 -0400
Message-ID: <1163653.1690036520@sss.pgh.pa.us> (raw)
In-Reply-To: <CALj2ACVH=Eqri6tJ2oOBkiBpAF4wVcbPNsOhWoZCG0=RyD-1Qw@mail.gmail.com>
References: <E1qMsYH-000dLZ-HX@gemulon.postgresql.org>
<ef0de9713e605451f1b60b30648c5ee900b2394c.camel@j-davis.com>
<CALj2ACVH=Eqri6tJ2oOBkiBpAF4wVcbPNsOhWoZCG0=RyD-1Qw@mail.gmail.com>
Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> writes:
> On Sat, Jul 22, 2023 at 4:22 AM Jeff Davis <pgsql@j-davis.com> wrote:
>> On Fri, 2023-07-21 at 16:00 +0000, Tom Lane wrote:
>>> Fix calculation of relid sets for partitionwise child joins.
>> In CI, I'm seeing a compiler warning here:
>> [22:28:11.772] joinrels.c: In function ‘try_partitionwise_join’:
>> [22:28:11.772] joinrels.c:1546:11: error: variable ‘child_joinrelids’
>> set but not used [-Werror=unused-but-set-variable]
Right, I failed to test it without --enable-cassert, so I did not
see this warning.
> Might have to mark the child_joinrelids PG_USED_FOR_ASSERTS_ONLY.
It seemed better to me to put the adjust_child_relids call into
the Assert macro, so the compiler knows it doesn't have to run
adjust_child_relids in the non-Assert case.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, bharath.rupireddyforpostgres@gmail.com, pgsql@j-davis.com, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix calculation of relid sets for partitionwise child joins.
In-Reply-To: <1163653.1690036520@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox