From: Tom Lane <tgl@sss.pgh.pa.us>
To: Simon Riggs <simon@2ndquadrant.com>
Cc: pgsql-committers@lists.postgresql.org, Konstantin Knizhnik <k.knizhnik@postgrespro.ru>
Subject: Re: pgsql: Allow HOT updates for some expression indexes
Date: Tue, 27 Mar 2018 17:07:15 -0400
Message-ID: <11787.1522184835@sss.pgh.pa.us> (raw)
In-Reply-To: <CANP8+jKLMvyHqy7PTn-HBEvSh3-dH+OOEiwJJYV2XMkF2UshtQ@mail.gmail.com>
References: <E1f0tqf-0007Vs-JZ@gemulon.postgresql.org>
<CANP8+jLd4USe=yuN77NVQOyijO9Wn4DFNt+iLr74sBVuCSBnsQ@mail.gmail.com>
<CANP8+jKLMvyHqy7PTn-HBEvSh3-dH+OOEiwJJYV2XMkF2UshtQ@mail.gmail.com>
Simon Riggs <simon@2ndquadrant.com> writes:
> On 27 March 2018 at 20:11, Simon Riggs <simon@2ndquadrant.com> wrote:
>> Buildfarm failure seen, investigating
> Error on FreeBSD only , perhaps timing-related as a result of using
> pg_stat_get_xact_tuples_hot_updated()
> in tests.
It's by now obvious that it's not just "FreeBSD only".
The test script appears to imagine that pgstats outputs update
instantaneously. I'm rather astonished that it passes anywhere,
much less that it seemingly passes reliably enough for you
to have not been noticed in precommit testing.
The existing "stats" test moves mountains to get repeatable results,
and is pretty slow in consequence, and even so it doesn't always succeed.
I think that rather than going down that path, you should drop this test
approach and think of some other way.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, simon@2ndquadrant.com, k.knizhnik@postgrespro.ru
Subject: Re: pgsql: Allow HOT updates for some expression indexes
In-Reply-To: <11787.1522184835@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox