pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Noah Misch <noah@leadboat.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: pgsql-committers@postgresql.org
Subject: Re: pgsql: Improve performance of SendRowDescriptionMessage.
Date: Thu, 12 Oct 2017 22:44:20 -0400
Message-ID: <12267.1507862660@sss.pgh.pa.us> (raw)
In-Reply-To: <20171013023536.GA492146@rfd.leadboat.com>
References: <E1e2RML-0002do-Lc@gemulon.postgresql.org>
	<307.1507819498@sss.pgh.pa.us>
	<20171012230844.ye4tnye2shysvqpk@alap3.anarazel.de>
	<20171013023536.GA492146@rfd.leadboat.com>
List-Unsubscribe:  <mailto:majordomo@postgresql.org?body=unsub%20pgsql-committers>

Noah Misch <noah@leadboat.com> writes:
> On Thu, Oct 12, 2017 at 04:08:44PM -0700, Andres Freund wrote:
>> Noah, any chance you could force restrict to off on that animal?

> I can confirm it allows "make check" to pass.

So that leaves us with two theories:

1. hornet's compiler contains a bug that causes it to misoptimize
in the presence of "restrict".

2. There's a bug in the way HEAD is applying "restrict", which happens
not to manifest on other platforms.

While I have to agree with Andres' evident feeling that it's probably
#1, I do not think we should dismiss #2 without inquiring a bit
harder.  It would be really useful, I think, if we could characterize
exactly how the RowDescription output is broken in that build.
Noah, could you capture some of those messages somehow?

			regards, tom lane


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers



view thread (21+ messages)  latest in thread

Message-ID: <12267.1507862660@sss.pgh.pa.us>
Permalink:  ../12267.1507862660@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/12267.1507862660@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, noah@leadboat.com, andres@anarazel.de
  Subject: Re: pgsql: Improve performance of SendRowDescriptionMessage.
  In-Reply-To: <12267.1507862660@sss.pgh.pa.us>
  References: <E1e2RML-0002do-Lc@gemulon.postgresql.org> <307.1507819498@sss.pgh.pa.us> <20171012230844.ye4tnye2shysvqpk@alap3.anarazel.de> <20171013023536.GA492146@rfd.leadboat.com> <12267.1507862660@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox