pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add a regression test for allow_system_table_mods
Date: Fri, 29 Nov 2019 10:27:47 -0500
Message-ID: <13656.1575041267@sss.pgh.pa.us> (raw)
In-Reply-To: <E1iacW7-0003h6-6U@gemulon.postgresql.org>
References: <E1iacW7-0003h6-6U@gemulon.postgresql.org>

Peter Eisentraut <peter@eisentraut.org> writes:
> Add a regression test for allow_system_table_mods

Oooh ... some of the buildfarm members are pointing out that this
didn't follow a project convention:

@@ -153,6 +153,7 @@
 ROLLBACK;
 -- reserved tablespace name
 CREATE TABLESPACE pg_foo LOCATION '/no/such/location';
+WARNING:  tablespaces created by regression test cases should have names starting with "regress_"
 ERROR:  directory "/no/such/location" does not exist
 -- triggers
 CREATE TRIGGER t1 BEFORE INSERT ON pg_description EXECUTE FUNCTION tf1();

			regards, tom lane





view thread (9+ messages)  latest in thread

Message-ID: <13656.1575041267@sss.pgh.pa.us>
Permalink:  ../13656.1575041267@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/13656.1575041267@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, peter@eisentraut.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Add a regression test for allow_system_table_mods
  In-Reply-To: <13656.1575041267@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox