From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Geoghegan <pg@bowt.ie>
Cc: pgsql-committers <pgsql-committers@lists.postgresql.org>
Subject: Re: pgsql: Make heap TID a tiebreaker nbtree index column.
Date: Wed, 20 Mar 2019 14:08:03 -0400
Message-ID: <13999.1553105283@sss.pgh.pa.us> (raw)
In-Reply-To: <CAH2-WzmFdW-e9+uG5BqzuW7YWBdL9=Vrwgmt5p6vndCeKJ5Z4w@mail.gmail.com>
References: <E1h6eep-0001Mw-Vd@gemulon.postgresql.org>
<CAH2-WzmFdW-e9+uG5BqzuW7YWBdL9=Vrwgmt5p6vndCeKJ5Z4w@mail.gmail.com>
Peter Geoghegan <pg@bowt.ie> writes:
> On Wed, Mar 20, 2019 at 10:05 AM Peter Geoghegan <pg@bowt.ie> wrote:
>> Make heap TID a tiebreaker nbtree index column.
> I see that this has caused SELinux test failures on rhinoceros (the
> ddl test fails). It looks like the output order is affected by the
> implementation details of nbtree, likely for some system catalog
> index. This is something that I've had to deal with in other places
> (with a lot of help from Tom).
The diffs all are related to the order of operations in a DROP OWNED BY
command, so I think blaming SELinux is just blaming the messenger.
This comes down to the point that we didn't do anything to ensure
drop order stability in shdepend-driven drops. Maybe we need to be
honest about that. Or do you have reason to think that your changes
will result in stability in that drop order anyway? If so, why?
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, pg@bowt.ie, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Make heap TID a tiebreaker nbtree index column.
In-Reply-To: <13999.1553105283@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox