pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Improve error reporting in jsonpath
3+ messages / 3 participants
[nested] [flat]
Commits from this thread:
2019-05-07 e5f9786317 Add jsonpath_encoding_1.out changes missed in 29ceacc3f9
* pgsql: Improve error reporting in jsonpath
@ 2019-05-07 22:03 Alexander Korotkov <akorotkov@postgresql.org>
0 siblings, 1 reply; 3+ messages in thread
From: Alexander Korotkov @ 2019-05-07 22:03 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Improve error reporting in jsonpath
This commit contains multiple improvements to error reporting in jsonpath
including but not limited to getting rid of following things:
* definition of error messages in macros,
* errdetail() when valueable information could fit to errmsg(),
* word "singleton" which is not properly explained anywhere,
* line breaks in error messages.
Reported-by: Tom Lane
Discussion: https://postgr.es/m/14890.1555523005%40sss.pgh.pa.us
Author: Alexander Korotkov
Reviewed-by: Tom Lane
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/29ceacc3f93720d3ebb7e7e999f8b7fe9622389c
Modified Files
--------------
src/backend/utils/adt/jsonpath_exec.c | 120 ++++++-------------
src/backend/utils/adt/jsonpath_gram.y | 6 +-
src/backend/utils/adt/jsonpath_scan.l | 23 ++--
src/test/regress/expected/jsonb_jsonpath.out | 137 ++++++++--------------
src/test/regress/expected/jsonpath.out | 61 ++++------
src/test/regress/expected/jsonpath_encoding.out | 18 +--
src/test/regress/expected/jsonpath_encoding_1.out | 12 +-
7 files changed, 130 insertions(+), 247 deletions(-)
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: pgsql: Improve error reporting in jsonpath
@ 2019-05-07 22:30 Tom Lane <tgl@sss.pgh.pa.us>
parent: Alexander Korotkov <akorotkov@postgresql.org>
0 siblings, 1 reply; 3+ messages in thread
From: Tom Lane @ 2019-05-07 22:30 UTC (permalink / raw)
To: Alexander Korotkov <akorotkov@postgresql.org>; +Cc: pgsql-committers@lists.postgresql.org
Alexander Korotkov <akorotkov@postgresql.org> writes:
> Improve error reporting in jsonpath
Buildfarm's not too happy --- looks like you forgot to update
jsonpath_encoding_1.out all the way.
regards, tom lane
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: pgsql: Improve error reporting in jsonpath
@ 2019-05-07 22:51 Alexander Korotkov <a.korotkov@postgrespro.ru>
parent: Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 3+ messages in thread
From: Alexander Korotkov @ 2019-05-07 22:51 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Alexander Korotkov <akorotkov@postgresql.org>; pgsql-committers <pgsql-committers@lists.postgresql.org>
On Wed, May 8, 2019 at 1:31 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Alexander Korotkov <akorotkov@postgresql.org> writes:
> > Improve error reporting in jsonpath
>
> Buildfarm's not too happy --- looks like you forgot to update
> jsonpath_encoding_1.out all the way.
What a oversight! Will fix immediately.
------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2019-05-07 22:51 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2019-05-07 22:03 pgsql: Improve error reporting in jsonpath Alexander Korotkov <akorotkov@postgresql.org>
2019-05-07 22:30 ` Tom Lane <tgl@sss.pgh.pa.us>
2019-05-07 22:51 ` Alexander Korotkov <a.korotkov@postgrespro.ru>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox