From: Alexander Korotkov <akorotkov@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Improve error reporting in jsonpath
Date: Tue, 07 May 2019 22:03:16 +0000
Message-ID: <E1hO8BA-0004Me-LP@gemulon.postgresql.org> (raw)
Improve error reporting in jsonpath
This commit contains multiple improvements to error reporting in jsonpath
including but not limited to getting rid of following things:
* definition of error messages in macros,
* errdetail() when valueable information could fit to errmsg(),
* word "singleton" which is not properly explained anywhere,
* line breaks in error messages.
Reported-by: Tom Lane
Discussion: https://postgr.es/m/14890.1555523005%40sss.pgh.pa.us
Author: Alexander Korotkov
Reviewed-by: Tom Lane
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/29ceacc3f93720d3ebb7e7e999f8b7fe9622389c
Modified Files
--------------
src/backend/utils/adt/jsonpath_exec.c | 120 ++++++-------------
src/backend/utils/adt/jsonpath_gram.y | 6 +-
src/backend/utils/adt/jsonpath_scan.l | 23 ++--
src/test/regress/expected/jsonb_jsonpath.out | 137 ++++++++--------------
src/test/regress/expected/jsonpath.out | 61 ++++------
src/test/regress/expected/jsonpath_encoding.out | 18 +--
src/test/regress/expected/jsonpath_encoding_1.out | 12 +-
7 files changed, 130 insertions(+), 247 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: akorotkov@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Improve error reporting in jsonpath
In-Reply-To: <E1hO8BA-0004Me-LP@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox