pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andrew Dunstan <andrew@dunslane.net>
To: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Remove command checks in tests of pg_basebackup and pg_receivewa
Date: Sat, 30 Apr 2022 16:52:54 -0400
Message-ID: <14402151-376b-a57a-6d0c-10ad12608e12@dunslane.net> (raw)
In-Reply-To: <E1nJpf1-0003FC-Od@gemulon.postgresql.org>
References: <E1nJpf1-0003FC-Od@gemulon.postgresql.org>


On 2022-02-14 Mo 23:41, Michael Paquier wrote:
> Remove command checks in tests of pg_basebackup and pg_receivewal
>
> The TAP tests of those commands have been checking if commands of "gzip"
> and "lz4" existed by launching them with an extra --version.  Based on
> the buildfarm, this is not required for "gzip" as the command always
> exists.  Since 1d084fb, "lz4" has a ./configure check doing the same
> thing.
>
> Reported-by: Andres Freund
> Discussion: https://postgr.es/m/20220212220643.ozuvq2k4cjkcnr2v@alap3.anarazel.de
> Discussion: https://postgr.es/m/Ygm2ADakjlqGc2Ro@paquier.xyz
>


This appears to have been misconceived, at least in the case of MSVC
builds, as I have just discovered. It is entirely possible to have the
lz4 libraries installed and build with them but not have the .exe, and
unlike the configure case the MSVC build system doesn't conduct any test
for it, resulting in a nasty looking TAP test failure. I assume similar
failures are possible with zstd and maybe gzip.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com






view thread (11+ messages)  latest in thread

Message-ID: <14402151-376b-a57a-6d0c-10ad12608e12@dunslane.net>
Permalink:  ../14402151-376b-a57a-6d0c-10ad12608e12@dunslane.net/
Also on:    postgresql.org/message-id/14402151-376b-a57a-6d0c-10ad12608e12@dunslane.net

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andrew@dunslane.net, michael@paquier.xyz
  Subject: Re: pgsql: Remove command checks in tests of pg_basebackup and pg_receivewa
  In-Reply-To: <14402151-376b-a57a-6d0c-10ad12608e12@dunslane.net>
  References: <E1nJpf1-0003FC-Od@gemulon.postgresql.org> <14402151-376b-a57a-6d0c-10ad12608e12@dunslane.net>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox