From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: pgsql-committers <pgsql-committers@postgresql.org>
Subject: Re: pgsql: Add support for coordinating record typmods among parallel worke
Date: Thu, 14 Sep 2017 23:45:20 -0400
Message-ID: <14932.1505447120@sss.pgh.pa.us> (raw)
In-Reply-To: <CAEepm=08r6ssWnM7wOAN=omz=s9DHujsJjJY6SN_PTHayPR0hw@mail.gmail.com>
References: <E1dsguX-00056N-9x@gemulon.postgresql.org>
<13971.1505445491@sss.pgh.pa.us>
<CAEepm=08r6ssWnM7wOAN=omz=s9DHujsJjJY6SN_PTHayPR0hw@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-committers>
Thomas Munro <thomas.munro@enterprisedb.com> writes:
> My compiler, C++ and more recent C standards are OK with identical
> redefinition of a typedef like that, but not the older standards or
> those particular compilers. D'oh. (I should figure out how to make
> my automatic patch tester this fussy). I think we should probably
> just do this:
Our usual locution for this sort of thing is to use
"struct SharedRecordTypmodRegistry" in headers instead of
the typedef name, if we don't want to pull in the header
where the typedef is defined. It might be all right to do
what you suggest, but we've been burnt in the past by circular
dependencies and/or pulling some header into essentially
the entire build (which tends to lead to a mess down the road).
I'd generally lean in the direction of not adding #includes to
header files except where absolutely necessary.
regards, tom lane
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, thomas.munro@enterprisedb.com, andres@anarazel.de
Subject: Re: pgsql: Add support for coordinating record typmods among parallel worke
In-Reply-To: <14932.1505447120@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox