pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alexander Korotkov <aekorotkov@gmail.com>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Alexander Korotkov <akorotkov@postgresql.org>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Detecting pointer misalignment (was Re: pgsql: Implementation of subscripting for jsonb)
Date: Fri, 12 Feb 2021 17:55:00 -0500
Message-ID: <1611008.1613170500@sss.pgh.pa.us> (raw)
In-Reply-To: <CAPpHfdtEeg4Ax09kCHGupiG8rUuL1EAhdHUdbjCxM=JgrSCoDw@mail.gmail.com>
References: <E1l6Jjn-0000kp-75@gemulon.postgresql.org>
	<37bb56a0-391d-759d-771b-9c1d8c15a84b@iki.fi>
	<3293925.1612163110@sss.pgh.pa.us>
	<CAPpHfdsne3=T=fMNU45PtxdhSL_J2PjLTeS8rwKnJzUR4YNd4w@mail.gmail.com>
	<CAPpHfdu8Jh0tySa50Zhkyg6gMvi2pQFdHAMiF+UkZNqsDLwTQw@mail.gmail.com>
	<475514.1612745257@sss.pgh.pa.us>
	<CAPpHfdvh+QrbBCo=uY=_fHK8w7yKr=Q4KGAtp=3tzp62SjODrA@mail.gmail.com>
	<CA+hUKGLs9xMUDY=Oh0uOyJysaY=NGg3y53q_Tr2C+LLqstYf6A@mail.gmail.com>
	<CAPpHfduDEYtWEB+xhM3PcP4bFwJ3aqZw7R7xFto8+pVDV5w-MA@mail.gmail.com>
	<1557041.1613150383@sss.pgh.pa.us>
	<CAPpHfdtEeg4Ax09kCHGupiG8rUuL1EAhdHUdbjCxM=JgrSCoDw@mail.gmail.com>

Alexander Korotkov <aekorotkov@gmail.com> writes:
> On Fri, Feb 12, 2021 at 8:19 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> So maybe it'd better be __GNUC__ >= 6 not __GNUC__ >= 5.  I think
>> we can wait a little bit for more reports before messing with that,
>> though.

> I've rechecked this in the documentation. no_sanitize attribute seems
> to appear since gcc 8.0.  Much later than alignment sanitizer itself.

Yeah, I'd just come to that conclusion from scraping the buildfarm
logs.  Good to see it confirmed in the manual though.

>> Once this does settle, should we consider back-patching so that it's
>> possible to run alignment checks in the back branches too?

> +1

Let's make sure we have a clean set of builds and then do that.

			regards, tom lane





view thread (15+ messages)  latest in thread

Message-ID: <1611008.1613170500@sss.pgh.pa.us>
Permalink:  ../1611008.1613170500@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1611008.1613170500@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, aekorotkov@gmail.com, thomas.munro@gmail.com, hlinnaka@iki.fi, akorotkov@postgresql.org, pgsql-hackers@lists.postgresql.org
  Subject: Re: Detecting pointer misalignment (was Re: pgsql: Implementation of subscripting for jsonb)
  In-Reply-To: <1611008.1613170500@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox