public inbox for [email protected]  

help / color / mirror / Atom feed

From: Peter Eisentraut <[email protected]>
To: Mark Dilger <[email protected]>
Cc: [email protected]
Cc: Tom Lane <[email protected]>
Subject: Re: pgsql: Generalize hash and ordering support in amapi
Date: Tue, 4 Mar 2025 17:46:01 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAHgHdKuCQ3Dh8wt9QxWRmezgE62qzYW86T9Mv1n5s3fOJ4G2dQ@mail.gmail.com>
References: <[email protected]>
	<[email protected]>
	<CAHgHdKuCQ3Dh8wt9QxWRmezgE62qzYW86T9Mv1n5s3fOJ4G2dQ@mail.gmail.com>

On 27.02.25 23:17, Mark Dilger wrote:
> The logic in equality_ops_are_compatible() was trusting that equality 
> operators found in an opfamily for btree or hash were ok, but not 
> trusting operators found in opfamilies of other AMs.  Now, after the 
> patch, other AMs can be marked as suitable.  That's really the core of 
> what the flag means:  "Can the system trust that equality operators 
> found in opfamilies of the AM are well-behaved", or something like 
> that.

Yeah, what might be a good English identifier for that?

>     I also object strongly to the fact that the comments for
>     equality_ops_are_compatible and comparison_ops_are_compatible
>     were not modified:
> 
>       * This is trivially true if they are the same operator.  Otherwise,
>       * we look to see if they can be found in the same btree or hash
>     opfamily.
> 
>       * This is trivially true if they are the same operator.  Otherwise,
>       * we look to see if they can be found in the same btree opfamily.
> 
> I agree these comments need updating.

Mark, can you suggest updated wording for those?

view thread (10+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: pgsql: Generalize hash and ordering support in amapi
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox