public inbox for [email protected]  

help / color / mirror / Atom feed

From: Peter Eisentraut <[email protected]>
To: Tom Lane <[email protected]>
Cc: Mark Dilger <[email protected]>
Cc: [email protected]
Subject: Re: pgsql: Generalize hash and ordering support in amapi
Date: Sat, 8 Mar 2025 09:45:07 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<CAHgHdKuCQ3Dh8wt9QxWRmezgE62qzYW86T9Mv1n5s3fOJ4G2dQ@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>

On 07.03.25 19:50, Tom Lane wrote:
> Peter Eisentraut <[email protected]> writes:
>> I have committed fixes for these issues along the lines you suggested.
> 
> Thanks.  There is a typo in hashhandler:
> 
> -   amroutine->amcancrosscompare = true;
> +   amroutine->amconsistentequality = true;
> +   amroutine->amconsistentequality = false;
> 
> The second line should be setting amconsistentordering = false.
> 
> Also, may I suggest one more thing?  I think the test in
> comparison_ops_are_compatible should be just
> 
> -           if (amroutine->amcanorder && amroutine->amconsistentordering)
> +           if (amroutine->amconsistentordering)
> 
> (and the comment for it needs adjustment too).  To my mind,
> amconsistentordering is a static declaration that operators
> within one of the AM's opfamilies are expected to have this
> property.  That could be true whether or not the AM is capable
> of returning tuples in order.  So although these flags might
> commonly be set together, I think they are independent
> properties.

Agreed, done.

view thread (10+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: pgsql: Generalize hash and ordering support in amapi
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox